Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of fix to NanoGENJets #41235

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

Cvico
Copy link
Contributor

@Cvico Cvico commented Mar 30, 2023

Backport of 41163. Description of the original PR can be found below. @swertz suggested that it would be good to have this fix in CMSSW_13_X just in case people compares nanoGEN jets from nanoAODv12 with nanoGEN produced with this release.

PR description
This PR includes a minimal change in the configuration file that is used for producing NanoGEN format: PhysicsTools/NanoAOD/python/nanogen_cff.py.

Additional information
This issue has been known for some time, but it was never fixed and included in the master branch up until know. Everything regarding this issue is discussed in 1 and 2.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 30, 2023

A new Pull Request was created by @Cvico (Carlos Vico Villalba) for CMSSW_13_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @simonepigazzini, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@Cvico Cvico changed the title Fix nanoGEN jets that were wrongly considering the neutrino contribut… Backport of fix to NanoGENJets Mar 30, 2023
@swertz
Copy link
Contributor

swertz commented Mar 30, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d9eae/31698/summary.html
COMMIT: 982887c
CMSSW: CMSSW_13_0_X_2023-03-30-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41235/31698/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 11 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554479
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3554450
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@swertz
Copy link
Contributor

swertz commented Mar 31, 2023

+1

Verbatim backport

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

backport of #41163

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 87c9792 into cms-sw:CMSSW_13_0_X Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants