Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GPU workflows [13.2.x] #42714

Merged
merged 4 commits into from
Sep 14, 2023

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 4, 2023

PR description:

Clean up the definition of the GPU workflows.
Drop 2022 MC GPU workflows.
Move Patatrack data workflows to 2023.
Add workflows for GPU validation and profiling on data.

PR validation:

New matrix workflows pass (tested in 13.3.x):

runTheMatrix.py -w gpu -l 141.008507,141.008508,141.008513,141.008514,141.008523,141.008524
...
141.008507_Run3-2023_JetMET2023B_RecoPixelOnlyTripletsGPU_Validation Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Sep  5 07:39:36 2023-date Tue Sep  5 07:29:23 2023; exit: 0 0 0 0
141.008508_Run3-2023_JetMET2023B_RecoPixelOnlyTripletsGPU_Profiling Step0-PASSED Step1-PASSED Step2-PASSED  - time date Tue Sep  5 07:37:50 2023-date Tue Sep  5 07:29:24 2023; exit: 0 0 0
141.008513_Run3-2023_JetMET2023B_RecoECALOnlyGPU_Validation Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Sep  5 07:39:40 2023-date Tue Sep  5 07:29:24 2023; exit: 0 0 0 0
141.008514_Run3-2023_JetMET2023B_RecoECALOnlyGPU_Profiling Step0-PASSED Step1-PASSED Step2-PASSED  - time date Tue Sep  5 07:37:48 2023-date Tue Sep  5 07:29:25 2023; exit: 0 0 0
141.008523_Run3-2023_JetMET2023B_RecoHCALOnlyGPU_Validation Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Sep  5 07:48:39 2023-date Tue Sep  5 07:37:48 2023; exit: 0 0 0 0
141.008524_Run3-2023_JetMET2023B_RecoHCALOnlyGPU_Profiling Step0-PASSED Step1-PASSED Step2-PASSED  - time date Tue Sep  5 07:41:42 2023-date Tue Sep  5 07:37:50 2023; exit: 0 0 0
6 6 6 3 tests passed, 0 0 0 0 failed

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #42713, in case it is requested.

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 4, 2023

backport #42713

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 4, 2023

enable gpu

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2023

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_13_2_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @srimanob, @cmsbuild, @AdrianoDee, @miquork, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @missirol, @slomeo, @fabiocos, @Martin-Grunewald this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 4, 2023

(wait for the 13.3.x tests to pass before testing in 13.2.x)

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 5, 2023

test parameters:

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 5, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb3425/34600/summary.html
COMMIT: 931e912
CMSSW: CMSSW_13_2_X_2023-09-04-2300/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42714/34600/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3197913
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3197888
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 40118
  • DQMHistoTests: Total failures: 21
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 40097
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

@sunilUIET
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fb1ad46 into cms-sw:CMSSW_13_2_X Sep 14, 2023
14 checks passed
@fwyzard fwyzard deleted the update_gpu_workflows_132x branch September 15, 2023 14:40
@mmusich
Copy link
Contributor

mmusich commented Oct 11, 2023

I am still not quite sure what mechanism provokes it, but reverting this PR locally on top of CMSSW_13_2_4 solves #42831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants