Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relval for Herwig Matchbox #43261

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

Dominic-Stafford
Copy link
Contributor

PR description:

Adds a new Herwig relval, 539, which tests running Madgraph inside Herwig using the "Matchbox" mode. Currently this process has a relatively large overhead (about 20 minutes) since it re-performs the Madgraph phase space integration every time - the addition of a gridpack system so that this does not need to be done is a high-priority item.

PR validation:

Have tested that the new relval runs in CMSSW_14_0_X

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43261/37650

  • This PR adds an extra 72KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dominic-Stafford for master.

It involves the following packages:

  • Configuration/Generator (generators)
  • Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @mkirsano, @GurpreetSinghChahal, @alberto-sanchez, @srimanob, @cmsbuild, @menglu21, @sunilUIET, @AdrianoDee, @SiewYan, @miquork can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @missirol, @slomeo, @fabiocos this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test workflow 539.0

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51b822/35777/summary.html
COMMIT: 266bf51
CMSSW: CMSSW_14_0_X_2023-11-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43261/35777/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 95 lines from the logs
  • Reco comparison results: 133 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3363028
  • DQMHistoTests: Total failures: 2401
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3360605
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@menglu21
Copy link
Contributor

+1

@srimanob
Copy link
Contributor

+Upgrade

@sunilUIET
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit aa2be5a into cms-sw:master Nov 22, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants