Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relval for Herwig Matchbox #43692

Merged

Conversation

Dominic-Stafford
Copy link
Contributor

PR description:

Adds a new Herwig relval, 539, which tests running Madgraph inside Herwig using the "Matchbox" mode. Currently this process has a relatively large overhead (about 20 minutes) since it re-performs the Madgraph phase space integration every time - the addition of a gridpack system so that this does not need to be done is a high-priority item.

PR validation:

Have tested that the new relval runs in CMSSW_12_4_X

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #43261 for validation of changes to the matchbox for use in 2022 production

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dominic-Stafford for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/Generator (generators)
  • Configuration/PyReleaseValidation (pdmv, upgrade)

@sunilUIET, @mkirsano, @AdrianoDee, @cmsbuild, @GurpreetSinghChahal, @SiewYan, @bbilin, @menglu21, @srimanob, @subirsarkar, @miquork, @alberto-sanchez can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald, @makortel, @slomeo, @fabiocos this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 10, 2024

cms-bot internal usage

@srimanob
Copy link
Contributor

please test workflow 539.0

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ecb579/36782/summary.html
COMMIT: 747adac
CMSSW: CMSSW_12_4_X_2024-01-07-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43692/36782/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3766083
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3766059
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 167 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Contributor

+pdmv

@menglu21
Copy link
Contributor

+1

@srimanob
Copy link
Contributor

+Upgrade

New Herwig Matchbox workflow runs fine.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ac30751 into cms-sw:CMSSW_12_4_X Jan 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants