Z vertex multi layout #43952

ericcano · 2024-02-13T16:07:36Z

PR description:

This PR splits ZVertexSoA into two layouts inside a multi collection: one related to vertices, and one related to tracks.
~~It requires #40285 which is merged but not in any IB yet,~~

This is currently a direct translation of the code. As stated in its comment, the field ndof is sometimes used with vertex indices (and hence not used fully). This could be reviewed separately.

PR validation:

All unit tests from affected modules pass.

ericcano · 2024-02-13T16:08:03Z

This PR cannot be merged in master so I will rebase it.

cmsbuild · 2024-02-13T16:08:06Z

cms-bot internal usage

cmsbuild · 2024-02-13T16:13:12Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43952/38829

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43952/38829/cms-checkout-topic.log

DataFormats/VertexSoA/src/classes_def.xml

cmsbuild · 2024-02-15T11:16:03Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43952/38885

This PR adds an extra 52KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQM/SiPixelHeterogeneous/plugins/SiPixelCompareVertexSoAAlpaka.cc modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
- File RecoTauTag/HLTProducers/src/L2TauTagNNProducerAlpaka.cc modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
- File RecoTracker/PixelVertexFinding/plugins/alpaka/vertexFinder.dev.cc modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43952/38885/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43952/38885/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2024-02-15T11:26:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43952/38886

This PR adds an extra 56KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQM/SiPixelHeterogeneous/plugins/SiPixelCompareVertexSoAAlpaka.cc modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
- File RecoTauTag/HLTProducers/src/L2TauTagNNProducerAlpaka.cc modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
- File RecoTracker/PixelVertexFinding/plugins/alpaka/vertexFinder.dev.cc modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964

cmsbuild · 2024-03-12T12:14:04Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43952/39433

This PR adds an extra 52KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQM/SiPixelHeterogeneous/plugins/SiPixelCompareVertexSoAAlpaka.cc modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
- File RecoTauTag/HLTProducers/src/L2TauTagNNProducerAlpaka.cc modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
- File RecoTracker/PixelVertexFinding/plugins/alpaka/vertexFinder.dev.cc modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43952/39433/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43952/39433/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

ericcano · 2024-03-12T12:28:35Z

The conflicts were fixed. They only impacted the unit test.

…llection. Removes versioning info from class description for dictionnaries. Ports comments from CUDA version.

cmsbuild · 2024-03-12T12:49:53Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43952/39434

This PR adds an extra 52KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQM/SiPixelHeterogeneous/plugins/SiPixelCompareVertexSoAAlpaka.cc modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
- File RecoTauTag/HLTProducers/src/L2TauTagNNProducerAlpaka.cc modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
- File RecoTracker/PixelVertexFinding/plugins/alpaka/vertexFinder.dev.cc modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964

cmsbuild · 2024-03-12T12:50:16Z

Pull request #43952 was updated. @tjavaid, @nothingface0, @mmusich, @mandrenguyen, @rvenditti, @syuvivida, @antoniovagnerini, @makortel, @Martin-Grunewald, @cmsbuild, @fwyzard, @jfernan2 can you please check and sign again.

slava77 · 2024-04-20T04:46:50Z

@ericcano @fwyzard
please clarify on the plans for this PR.
Thank you.

fwyzard · 2024-04-21T00:36:25Z

@slava77 given the complexity of the changes, I am thinking to hold this off while we look for a more flexible approach.

I would like to keep this PR open as a reminder of the current implementation.

fwyzard · 2024-06-20T13:52:53Z

please close

fwyzard · 2024-06-20T13:53:38Z

We decided to keep this as a draft and as a reminder, but not merge it in its current form.

cmsbuild added this to the CMSSW_14_1_X milestone Feb 13, 2024

cmsbuild added reconstruction-pending dqm-pending hlt-pending pending-signatures tests-pending orp-pending code-checks-pending heterogeneous-pending tracking trk labels Feb 13, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 13, 2024

This was referenced Feb 14, 2024

Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964

Closed

Fix LHCInfoPer* PopCons to produce lumi-type IOVs when running in duringFill mode #43837

Merged

makortel reviewed Feb 14, 2024

View reviewed changes

DataFormats/VertexSoA/src/classes_def.xml Outdated Show resolved Hide resolved

ericcano force-pushed the ZVertexMultiLayout branch from c344dbb to 4ee4c37 Compare February 15, 2024 11:09

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 15, 2024

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Feb 15, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 15, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 5, 2024

ericcano force-pushed the ZVertexMultiLayout branch from f827097 to f086201 Compare March 12, 2024 12:08

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-rejected labels Mar 12, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 12, 2024

Splits ZVertexSoA into 2 layouts and wraps those in a multi layout co…

7dbd9b0

…llection. Removes versioning info from class description for dictionnaries. Ports comments from CUDA version.

ericcano force-pushed the ZVertexMultiLayout branch from f086201 to 7dbd9b0 Compare March 12, 2024 12:41

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 12, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 12, 2024

cmsbuild mentioned this pull request Apr 11, 2024

Reorganise alpaka kernel loop functions #44712

Merged

cmsbuild mentioned this pull request Apr 22, 2024

Migrate assert to to ALPAKA_ASSERT_ACC #44802

Merged

This was referenced Jun 5, 2024

L2TauTagNNProducerAlpaka: do not call TF inference with empty grid #45147

Merged

Including more general DQM compare modules for pixel tracks objects #45206

Merged

cmsbuild closed this Jun 20, 2024

fwyzard mentioned this pull request Aug 26, 2024

Follow up to the Pixel alpaka migration #43796

Open

2 tasks

fwyzard mentioned this pull request Sep 4, 2024

Update to relval_gpu.pyfor Alpaka and Pixel Triplets Alpaka Workflows #45694

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Z vertex multi layout #43952

Z vertex multi layout #43952

ericcano commented Feb 13, 2024 •

edited

Loading

ericcano commented Feb 13, 2024

cmsbuild commented Feb 13, 2024 •

edited

Loading

cmsbuild commented Feb 13, 2024

cmsbuild commented Feb 15, 2024

cmsbuild commented Feb 15, 2024

cmsbuild commented Mar 12, 2024

ericcano commented Mar 12, 2024

cmsbuild commented Mar 12, 2024

cmsbuild commented Mar 12, 2024

slava77 commented Apr 20, 2024

fwyzard commented Apr 21, 2024

fwyzard commented Jun 20, 2024

fwyzard commented Jun 20, 2024

Z vertex multi layout #43952

Z vertex multi layout #43952

Conversation

ericcano commented Feb 13, 2024 • edited Loading

PR description:

PR validation:

ericcano commented Feb 13, 2024

cmsbuild commented Feb 13, 2024 • edited Loading

cmsbuild commented Feb 13, 2024

cmsbuild commented Feb 15, 2024

cmsbuild commented Feb 15, 2024

cmsbuild commented Mar 12, 2024

ericcano commented Mar 12, 2024

cmsbuild commented Mar 12, 2024

cmsbuild commented Mar 12, 2024

slava77 commented Apr 20, 2024

fwyzard commented Apr 21, 2024

fwyzard commented Jun 20, 2024

fwyzard commented Jun 20, 2024

ericcano commented Feb 13, 2024 •

edited

Loading

cmsbuild commented Feb 13, 2024 •

edited

Loading