Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cfi file fixes (auto-port to 72X as well) #4413

Merged
merged 4 commits into from Jul 3, 2014

Conversation

Martin-Grunewald
Copy link
Contributor

More cfi file fixes (auto-port to 72X as well)

More py file syntax fixes as flagged by ConfDB parsing.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_1_X.

More cfi file fixes (auto-port to 72X as well)

It involves the following packages:

DQM/EcalMonitorClient
EventFilter/Utilities
RecoTauTag/TauTagTools

The following packages do not have a category, yet:

DQM/EcalMonitorClient

@nclopezo, @emeschi, @cmsbuild, @StoyanStoynev, @slava77, @mommsen, @Degano, @ktf can you please review it and eventually sign? Thanks.
@jpavel, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor Author

@ktf
Why does this trigger a new-package message?
The package DQM/EcalMonitorClient already exists!

@cmsbuild
Copy link
Contributor

Pull request #4413 was updated. @nclopezo, @emeschi, @cmsbuild, @StoyanStoynev, @slava77, @mommsen, @Degano, @ktf can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

+1
Jenkins fine except few known issues unrelated to this PR (wf 25; pixel and CASTOR diffs in DQM in various wf; not seen in local tests except for CASTOR).
Tested 8a47892 on top of CMSSW_7_1_X_2014-06-27-1400. No diffs (short matrix + tests on wf 202 /TTBAR with PU/; FWLite + DQM script comparisons). Tests included timing and RECO event content in wf 202.

@Martin-Grunewald
Copy link
Contributor Author

Hi Remi, @mommsen

Can you please still sign this one (also so that it gets forward ported to 72X).

@mommsen
Copy link
Contributor

mommsen commented Jun 30, 2014

+1

davidlange6 added a commit that referenced this pull request Jul 1, 2014
Cfi file fixes for 72X (same as already for 71X: #4405 and #4413)
davidlange6 added a commit that referenced this pull request Jul 3, 2014
More cfi file fixes (auto-port to 72X as well)
@davidlange6 davidlange6 merged commit 2f0617a into cms-sw:CMSSW_7_1_X Jul 3, 2014
@Martin-Grunewald Martin-Grunewald deleted the MoreCfiFileFixes branch July 4, 2014 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants