Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cfi file fixes for 72X (same as already for 71X: #4405 and #4413) #4448

Merged
merged 1 commit into from Jul 1, 2014

Conversation

Martin-Grunewald
Copy link
Contributor

Cfi fixes for72x (this is combining the 71X PRs #4405 and #4413 for 72X - now that we no longer forward port)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_2_X.

Cfi file fixes for 72X (same as already for 71X: #4405 and #4413)

It involves the following packages:

DQM/EcalMonitorClient
EventFilter/Utilities
RecoTauTag/TauTagTools
SLHCUpgradeSimulations/Configuration

The following packages do not have a category, yet:

DQM/EcalMonitorClient

@civanch, @nclopezo, @emeschi, @mdhildreth, @cmsbuild, @StoyanStoynev, @slava77, @mommsen, @Degano, @ktf can you please review it and eventually sign? Thanks.
@jpavel, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@mommsen
Copy link
Contributor

mommsen commented Jun 30, 2014

+1

@civanch
Copy link
Contributor

civanch commented Jun 30, 2014

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

+1
Jenkins OK. This PR is identical to #4413 (71X) except the SLHCUpgradeSimulations/Configuration/
part which is identical to #4405. It is also related to #4445 (which superseded #4413).
For the record - there is one failure in the Unit tests (missing DQM file in DQMServices/FwkIO) not related to the PR.

davidlange6 added a commit that referenced this pull request Jul 1, 2014
Cfi file fixes for 72X (same as already for 71X: #4405 and #4413)
@davidlange6 davidlange6 merged commit e78919e into cms-sw:CMSSW_7_2_X Jul 1, 2014
@Martin-Grunewald Martin-Grunewald deleted the CfiFixesFor72X branch July 1, 2014 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants