Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSSM Hbb trigger dqm updates for 2024 triggers [14_1_X] #44284

Conversation

robervalwalsh
Copy link
Contributor

PR description:

This PR contains updates to the trigger DQM for the modified MSSM Hbb triggers for 2024.

It mainly consists in updating the following:

  • trigger paths and trigger objects names
  • offline btagging for the relative efficiencies
  • moving from HIG → SUS

PR validation:

Release: CMSSW_14_1_X_2024-02-29-2300

runTheMatrix.py -l limited -i all --ibeos

  • All 2024 tests passed. Only one 2011 test failed (see below), which is not related to the updates requested here.
  • 48 47 45 35 18 1 1 1 1 1 1 tests passed, 0 0 1 0 0 0 0 0 0 0 0 failed
1000.0_RunMinBias2011A Step0-PASSED Step1-PASSED Step2-FAILED Step3-NOTRUN Step4-NOTRUN  - time date Fri Mar  1 10:42:17 2024-date Fri Mar  1 10:36:06 2024; exit: 0 0 22016 0 0

%MSG-w SiStripRawToDigi:  SiStripRawToDigiModule:siStripDigis@endStream  01-Mar-2024 10:40:46 CET PostEndProcessBlock
[sistrip::RawToDigiUnpacker::createDigis] warnings:
NULL pointer to FEDRawData for FED (100)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but it should be backported to CMSSW_14_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44284/39304

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2024

A new Pull Request was created by @robervalwalsh for master.

It involves the following packages:

  • DQMOffline/Trigger (dqm)
  • HLTriggerOffline/Higgs (dqm)

@tjavaid, @nothingface0, @antoniovagnerini, @rvenditti, @syuvivida, @cmsbuild can you please review it and eventually sign? Thanks.
@mtosi, @trocino, @Fedespring, @missirol, @rociovilar, @jhgoh, @cericeci, @HuguesBrun this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Mar 1, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e716b/37860/summary.html
COMMIT: 2f68be4
CMSSW: CMSSW_14_1_X_2024-03-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44284/37860/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 36 lines from the logs
  • Reco comparison results: 56 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3337986
  • DQMHistoTests: Total failures: 1358
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3336606
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 6059.410000000002 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 1003.781 KiB HLT/SUS
  • DQMHistoSizes: changed ( 12834.0,... ): -133.591 KiB HLT/HIG
  • DQMHistoSizes: changed ( 12834.0,... ): -7.980 KiB HLT/Higgs
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Mar 6, 2024

@robervalwalsh thanks for this. We'll need also a 14.0.X backport for the data-taking release.

@tjavaid
Copy link

tjavaid commented Mar 7, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@mmusich
Copy link
Contributor

mmusich commented Mar 11, 2024

We'll need also a 14.0.X backport for the data-taking release.

to speed up integration I took the liberty of opening a backport #44366 (@robervalwalsh FYI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants