MSSM Hbb trigger dqm updates for 2024 triggers [14.0.X]

[mmusich]

backport of #44284

PR description:

This PR contains updates to the trigger DQM for the modified MSSM Hbb triggers for 2024.

• https://its.cern.ch/jira/browse/CMSHLT-3024
• https://its.cern.ch/jira/browse/CMSHLT-3080

It mainly consists in updating the following:

• trigger paths and trigger objects names
• offline btagging for the relative efficiencies
• moving from HIG → SUS

PR validation:

see master PR

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #44284

[cmsbuild]

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

• DQMOffline/Trigger (dqm)
• HLTriggerOffline/Higgs (dqm)

@nothingface0, @cmsbuild, @tjavaid, @syuvivida, @rvenditti, @antoniovagnerini can you please review it and eventually sign? Thanks.
@missirol, @rociovilar, @cericeci, @Fedespring, @mtosi, @HuguesBrun, @jhgoh, @trocino this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from MSSM Hbb trigger dqm updates for 2024 triggers [14_1_X] #44284

[cmsbuild]

cms-bot internal usage

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7504b9/38031/summary.html
COMMIT: 706d431
CMSSW: CMSSW_14_0_X_2024-03-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44366/38031/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 137 lines from the logs
• Reco comparison results: 67 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3341473
• DQMHistoTests: Total failures: 1355
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3340096
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 6059.410000000002 KiB( 48 files compared)
• DQMHistoSizes: changed ( 12834.0,... ): 1003.781 KiB HLT/SUS
• DQMHistoSizes: changed ( 12834.0,... ): -133.591 KiB HLT/HIG
• DQMHistoSizes: changed ( 12834.0,... ): -7.980 KiB HLT/Higgs
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mmusich]

@cms-sw/dqm-l2 can you please review and sign?

[tjavaid]

Hi @mmusich , Looking into it. For some reason, I do not see bin-by-bin comparison plots produced. I do not see any error in the log file.

[mmusich]

@tjavaid this is a verbatim backport of the master PR (that you signed).

[tjavaid]

@tjavaid this is a verbatim backport of the master PR (that you signed).

Yes, that I know. I do not see any issue with this backport PR (looking at failed comparisons seems fine) but as a usual practice we also look at bin-by-bin plots e.g. as we can see them from #44284 (it's master PR).

[mmusich]

So what's the plan here? This cannot be stalled. It is necessary for the offline HLT monitoring for the 2024 trigger menu. @tjavaid

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7504b9/38091/summary.html
COMMIT: 706d431
CMSSW: CMSSW_14_0_X_2024-03-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44366/38091/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 40 lines from the logs
• Reco comparison results: 65 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3341473
• DQMHistoTests: Total failures: 1355
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3340096
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 6059.410000000002 KiB( 48 files compared)
• DQMHistoSizes: changed ( 12834.0,... ): 1003.781 KiB HLT/SUS
• DQMHistoSizes: changed ( 12834.0,... ): -133.591 KiB HLT/HIG
• DQMHistoSizes: changed ( 12834.0,... ): -7.980 KiB HLT/Higgs
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tjavaid]

Hi @mmusich , we still do not see the bin-by-bin plots in this round of tests. Our software expert @nothingface0 figured out it is not due to the issue we had back in December 2023. More likely the issue is related to Index DB for which @nothingface0 is already working on it to have the plots back as soon as possible.

[mmusich]

@tjavaid what's the timeline for fixing the issue? I would like to avoid loosing the next release because of internal DQM tools issues. Can you base your judgement on the master PR?

[tjavaid]

@tjavaid what's the timeline for fixing the issue? I would like to avoid loosing the next release because of internal DQM tools issues. Can you base your judgement on the master PR?

@mmusich , it is a bit hard to estimate it (perhaps @nothingface0 can better quote), but we think it is okay to sign it based on the comparisons and with the fact that master #44284 is already signed.

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1