Add Veto Threshold to HCAL TP Emulator

[JHiltbrand]

PR description:

This PR incorporates a threshold for vetoing when applying the FIR filter during emulation of HCAL TP energy reconstruction in HB and HE. The veto threshold is taken from the auxi2 field of the HcalTPChannelParameters object for robust control of the veto threshold online and offline.

Small change in logic is incurred at L519 of HcalTrigPrimAlgo, where check_sat is now only defined by saturation in BX0 or BX1.

ATTN: @Michael-Krohn, @abdoulline, @jhakala

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is targeting 14_1_X; however, a backport shall be prepared for 14_0_X.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44373/39421

• This PR adds an extra 60KB to repository

[cmsbuild]

A new Pull Request was created by @JHiltbrand for master.

It involves the following packages:

• CalibCalorimetry/HcalTPGAlgos (alca, l1)
• CaloOnlineTools/HcalOnlineDb (db)
• SimCalorimetry/HcalTrigPrimAlgos (l1)
• SimCalorimetry/HcalTrigPrimProducers (l1)

@perrotta, @francescobrivio, @cmsbuild, @aloeliger, @saumyaphor4252, @consuegs, @epalencia can you please review it and eventually sign? Thanks.
@bsunanda, @yuanchao, @sameasy, @mmusich, @rovere, @missirol, @rsreds, @PonIlya, @abdoulline, @tocheng this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[perrotta]

A couple of minor comments...

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44373/39432

• This PR adds an extra 56KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44373/39432/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44373/39432/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44373/39435

• This PR adds an extra 56KB to repository

[cmsbuild]

Pull request #44373 was updated. @aloeliger, @saumyaphor4252, @perrotta, @consuegs, @francescobrivio, @cmsbuild, @epalencia can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44373/39441

• This PR adds an extra 100KB to repository

[cmsbuild]

Pull request #44373 was updated. @saumyaphor4252, @consuegs, @perrotta, @francescobrivio, @cmsbuild, @aloeliger, @epalencia can you please check and sign again.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a03f1/38425/summary.html
COMMIT: 22ea6d7
CMSSW: CMSSW_14_1_X_2024-03-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44373/38425/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 29 lines from the logs
• Reco comparison results: 53 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297857
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297826
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

[aloeliger]

+l1

• re-sign

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[malbouis]

@saumyaphor4252 , since you are ORM this week: HCal would like to have the backport of this PR (to be submitted soon by @JHiltbrand ) to be included in the next 14_0_X release build. It is needed at Tier0/DQM/HLT as soon as possible.

[JHiltbrand]

@saumyaphor4252 , since you are ORM this week: HCal would like to have the backport of this PR (to be submitted soon by @JHiltbrand ) to be included in the next 14_0_X release build. It is needed at Tier0/DQM/HLT as soon as possible.

Thanks @malbouis and @saumyaphor4252 ! For reference, the backport to 14_0_X can now be found in #44556.

[antoniovilela]

+1