Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to 14_0_X (#44337)]: Add Veto Threshold to HCAL TP Emulator #44556

Merged

Conversation

JHiltbrand
Copy link
Contributor

PR description:

As copied from #44373:

This PR incorporates a threshold for vetoing when applying the FIR filter during emulation of HCAL TP energy reconstruction in HB and HE. The veto threshold is taken from the auxi2 field of the HcalTPChannelParameters object for robust control of the veto threshold online and offline.

Small change in logic is incurred at L519 of HcalTrigPrimAlgo, where check_sat is now only defined by saturation in BX0 or BX1.

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of #44373 to target the 14_0_X release cycle.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2024

A new Pull Request was created by @JHiltbrand for CMSSW_14_0_X.

It involves the following packages:

  • CalibCalorimetry/HcalTPGAlgos (alca, l1)
  • CaloOnlineTools/HcalOnlineDb (db)
  • SimCalorimetry/HcalTrigPrimAlgos (l1)
  • SimCalorimetry/HcalTrigPrimProducers (l1)

@francescobrivio, @perrotta, @consuegs, @epalencia, @saumyaphor4252, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@rsreds, @missirol, @JanChyczynski, @tocheng, @sameasy, @abdoulline, @bsunanda, @mmusich, @rovere, @PonIlya, @yuanchao this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2024

cms-bot internal usage

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-421475/38455/summary.html
COMMIT: 3629240
CMSSW: CMSSW_14_0_X_2024-03-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44556/38455/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+1

@aloeliger
Copy link
Contributor

backport of #44373:

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

backport of #44373

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1e15ff1 into cms-sw:CMSSW_14_0_X Mar 28, 2024
10 checks passed
@JHiltbrand JHiltbrand deleted the hcalTPvetoThreshold_Backport_14_0_X branch April 2, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants