HLT Tau DQM for PNet taus #44613
HLT Tau DQM for PNet taus #44613
Conversation
|
This PR contains too many commits (345 >= 240) and will not be processed. |
|
This PR should contain only one commit: ba685e1 |
@slehti it looks like the branch you used got messed up. cmsrel CMSSW_14_1_X_2024-04-03-2300
cd CMSSW_14_1_X_2024-04-03-2300/src/
cmsenv
git cms-addpkg HLTriggerOffline/Tau/ DQMOffline/Trigger/
git cherry-pick ba685e111de17a178e612f4c42ba27c47c177261
git push my-cmssw +HEAD:HLTTauValidationUpdateApril2024_PNetTau |
slehti
force-pushed
the
HLTTauValidationUpdateApril2024_PNetTau
branch
from
ba685e1
to
177554d
Compare
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44613/39806
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44613/39808
|
|
A new Pull Request was created by @slehti for master. It involves the following packages:
@rvenditti, @antoniovagnerini, @tjavaid, @syuvivida, @nothingface0, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
-1 Failed Tests: RelVals RelVals-INPUT RelVals
RelVals-INPUT |
| hCounter_->setBinLabel(1, "all events"); | ||
| hCounter_->setBinLabel(2, "ref tau found"); | ||
| hCounter_->setBinLabel(3, "passed trg"); |
There was a problem hiding this comment.
| hCounter_->setBinLabel(1, "all events"); | |
| hCounter_->setBinLabel(2, "ref tau found"); | |
| hCounter_->setBinLabel(3, "passed trg"); | |
| if (hCounter_){ | |
| hCounter_->setBinLabel(1, "all events"); | |
| hCounter_->setBinLabel(2, "ref tau found"); | |
| hCounter_->setBinLabel(3, "passed trg"); | |
| } |
I think this is necessary, at least with this the exception is removed.
| hCounter_->Fill(0.5); | ||
| if (refCollection.taus.size() > 0) { | ||
| hCounter_->Fill(1.5); | ||
| if (hltPath_.fired(triggerResults)) | ||
| hCounter_->Fill(2.5); | ||
| } |
There was a problem hiding this comment.
| hCounter_->Fill(0.5); | |
| if (refCollection.taus.size() > 0) { | |
| hCounter_->Fill(1.5); | |
| if (hltPath_.fired(triggerResults)) | |
| hCounter_->Fill(2.5); | |
| } | |
| if(hCounter_) { | |
| hCounter_->Fill(0.5); | |
| if (refCollection.taus.size() > 0) { | |
| hCounter_->Fill(1.5); | |
| if (hltPath_.fired(triggerResults)) | |
| hCounter_->Fill(2.5); | |
| } | |
| } |
cmsbuild
added
tests-pending
code-checks-pending
and removed
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44613/39854
|
|
Pull request #44613 was updated. @cmsbuild, @nothingface0, @rvenditti, @tjavaid, @syuvivida, @antoniovagnerini can you please check and sign again. |
|
@cmsbuild, please test |
|
urgent
|
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-042ac9/38677/summary.html Comparison SummarySummary:
|
|
@cms-sw/dqm-l2 |
|
@slehti Can you also open the backport please. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
HLTTauDQM
Added support for making DQM plots for PNetTauh paths.
Added event counter for helping to find problems. Not appearing in the final DQM output.
Fixed some empty plots at kEverything level.
Changed one plot level from kEverything to kVital (bugfix)
In addition to the current plots, every HLT path with string PNetTauh in the path name will be picked up and monitoring plots made.
Tested with CMSSW_14_0_4 that the code compiles, runs and produces the plots, including the new plots for PNet taus.