Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT Tau DQM for PNet taus: backport for 14_0_X #44680

Merged

Conversation

slehti
Copy link
Contributor

@slehti slehti commented Apr 10, 2024

This is a 14_0_X backport for PR #44613 adding support for monitoring PNet taus. Used for monitoring 2024 data taking.

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Apr 10, 2024
@cmsbuild
Copy link
Contributor

This PR contains too many commits (1266 >= 240) and will not be processed.
Please ensure you have selected the correct target branch and consider squashing unnecessary commits.
The processing of this PR will resume once the commit count drops below the limit.

@slehti
Copy link
Contributor Author

slehti commented Apr 10, 2024

Hmm, 1,266 commits: I thought this was already solved in the original PR and the branch would contain only the new commits. Should i again cherry-pick and push?

@mmusich
Copy link
Contributor

mmusich commented Apr 10, 2024

@slehti you started from the wrong base branch.
You need to repeat the same procedure as #44613 (comment), (cherry-picking all three commits), but starting from the last IB of CMSSW_14_0_X

@mmusich
Copy link
Contributor

mmusich commented Apr 10, 2024

@slehti, something along:

cmsrel CMSSW_14_0_X_2024-04-09-2300
cd CMSSW_14_0_X_2024-04-09-2300/src/
cmsenv
git cms-addpkg HLTriggerOffline/Tau/ DQMOffline/Trigger/
git cherry-pick 177554de427679a2b0905bd9ac7800312c606ee2
git cherry-pick bb6cb5c38abd9be737e944b3e8ab926d2ebf43ed
git cherry-pick 17874ed3a974322e5dc1f0de8e0cd9ee481f3cb8
git push my-cmssw +HEAD:HLTTauValidationUpdateApril2024_PNetTau

should work

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2024

A new Pull Request was created by @slehti for CMSSW_14_0_X.

It involves the following packages:

  • DQMOffline/Trigger (dqm)
  • HLTriggerOffline/Tau (dqm)

@rvenditti, @nothingface0, @syuvivida, @cmsbuild, @antoniovagnerini, @tjavaid can you please review it and eventually sign? Thanks.
@trocino, @cericeci, @rociovilar, @mtosi, @missirol, @HuguesBrun, @jhgoh, @Fedespring this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented Apr 10, 2024

backport of #44613

@mmusich
Copy link
Contributor

mmusich commented Apr 10, 2024

@cmsbuild, please test

@saumyaphor4252
Copy link
Contributor

urgent

  • As discussed at ORP yesterday [1], not showstopper for operations but would be highly encouraged for the next 140X release

Regards,
ORM

[1] https://indico.cern.ch/event/1404047/

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-444af0/38725/summary.html
COMMIT: 5ff91d9
CMSSW: CMSSW_14_0_X_2024-04-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44680/38725/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 320 lines to the logs
  • Reco comparison results: 66 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3350124
  • DQMHistoTests: Total failures: 600
  • DQMHistoTests: Total nulls: 39
  • DQMHistoTests: Total successes: 3349463
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1980.9569999999999 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 5.757 KiB HLT/TAU
  • DQMHistoSizes: changed ( 12834.0,... ): 392.019 KiB HLT/TAU
  • DQMHistoSizes: changed ( 139.001 ): 3.699 KiB HLT/TAU
  • DQMHistoSizes: changed ( 141.042,... ): 131.790 KiB HLT/TAU
  • DQMHistoSizes: changed ( 4.22,... ): 2.685 KiB HLT/TAU
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

@cms-sw/dqm-l2
Let's get this in 14_0_5.
Thanks.

@tjavaid
Copy link

tjavaid commented Apr 10, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ad6a6b4 into cms-sw:CMSSW_14_0_X Apr 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants