[GenPartIsoProducer.cc] New plugin for gen-part isolation.

[bonanomi]

PR description:

• Replaces Computation of Isolation for GenParticles collection #44461 and uses one commit only, as the squashing of all the commits in that PR got messed up because of the synching with main of cmssw.
• Addition of one branch, called iso to the GenParticles collection.
• The computation of the GenParticles.iso is done in the GenPartIsoProducer.cc plugin.
• This PR is intended to solve the issues that different Higgs analyses (but probably the issue is wider) are facing when doing fiducial cross section measurement (done in miniAOD before). This issue has been discussed here and here.

PR validation:

• The usage of the available GenDressedLeptons is out of question because that collection would require too many modifications, with unknown impact on the users.
• The approach proposed here can be used by all analyses and it is not analysis/PAG specific.
• All the other collections are not modified (tested vs v12 and v13 nanoAOD). A more detailed comparison is done using GluGluHtoGG_M-125_TuneCP5_13p6TeV_amcatnloFXFX-pythia8/Run3Summer22EEMiniAODv4-130X_mcRun3_2022_realistic_postEE_v6-v2/MINIAODSIM and the dump of the collections in the current nanoAOD can be found here to be compared with the one obtained with this code, that can be found here.

[cmsbuild]

cms-bot internal usage

[bonanomi]

Hi @vlimant @hqucms @antoniovilela could you please refer to this? I closed #44461 as the squashing of all the commits got messed up, as I was working on the main branch of my fork and I was trying to keep it in synch with the main of cmssw while doing the development. This is much cleaner and only comprises one commit. Sorry for the mess!

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44623/39813

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/genparticles_cff.py modified in PR(s): Explicit lazy parsing in SimpleFlatTableProducer #44575
  • File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): [NanoAOD,BTVNano] Btvnano integration as customized module #43485
  • File PhysicsTools/NanoAOD/python/nanogen_cff.py modified in PR(s): Explicit lazy parsing in SimpleFlatTableProducer #44575

[cmsbuild]

A new Pull Request was created by @bonanomi for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@vlimant, @cmsbuild, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[vlimant]

enable nano

[vlimant]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0fb0a/38619/summary.html
COMMIT: 69e3a51
CMSSW: CMSSW_14_1_X_2024-04-04-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44623/38619/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 99 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 52 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3307717
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3307691
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.84 KiB( 47 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 0.115 KiB Physics/NanoAODDQM
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 16430
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 16430
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.61 KiB( 14 files compared)
• DQMHistoSizes: changed ( 2500.001,... ): 0.115 KiB Physics/NanoAODDQM
• Checked 51 log files, 29 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.574	2.553	0.021 ( +0.8% )	4.55	4.67	-2.5%	2.149	2.228
2500.001	2.722	2.703	0.019 ( +0.7% )	4.00	4.16	-3.8%	2.525	2.647
2500.002	2.667	2.643	0.024 ( +0.9% )	4.26	4.26	+0.0%	2.534	2.647
2500.01	1.318	1.318	0.000 ( +0.0% )	8.12	8.35	-2.6%	2.264	2.349
2500.011	1.739	1.739	0.000 ( +0.0% )	4.52	4.57	-1.0%	2.412	2.540
2500.012	1.580	1.580	0.000 ( +0.0% )	6.41	6.61	-3.0%	2.321	2.453
2500.1	2.216	2.196	0.019 ( +0.9% )	4.58	4.65	-1.4%	1.974	2.071
2500.2	2.331	2.313	0.019 ( +0.8% )	5.17	5.34	-3.2%	1.884	1.984
2500.21	1.181	1.181	0.000 ( +0.0% )	3.51	3.55	-1.2%	2.135	2.278
2500.211	1.545	1.545	0.000 ( +0.0% )	3.11	3.15	-1.3%	2.195	2.367
2500.3	2.087	2.069	0.018 ( +0.9% )	9.91	10.24	-3.2%	1.896	1.971
2500.301	2.665	2.642	0.023 ( +0.9% )	8.20	8.80	-6.8%	1.833	1.958
2500.31	7.159	7.159	0.000 ( +0.0% )	1.38	1.40	-1.5%	1.707	1.706
2500.311	1.564	1.564	0.000 ( +0.0% )	7.17	6.25	+14.8%	1.053	1.058
2500.312	540.453	540.453	0.000 ( +0.0% )	0.52	0.53	-2.9%	1.596	1.624
2500.313	817.689	817.689	0.000 ( +0.0% )	0.71	0.74	-3.9%	1.586	1.572
2500.32	1.255	1.255	0.000 ( +0.0% )	12.83	13.28	-3.4%	2.321	2.366
2500.321	1.642	1.642	0.000 ( +0.0% )	9.55	10.05	-5.0%	2.407	2.418
2500.322	1.163	1.163	0.000 ( +0.0% )	9.90	10.40	-4.8%	2.067	2.250
2500.323	1.758	1.758	0.000 ( +0.0% )	9.86	10.20	-3.3%	2.126	2.191
2500.324	3.093	3.093	0.000 ( +0.0% )	1.79	1.80	-0.5%	2.210	2.104
2500.325	1.789	1.789	0.000 ( +0.0% )	9.98	10.31	-3.2%	2.216	2.335
2500.4	2.245	2.227	0.017 ( +0.8% )	9.45	9.98	-5.3%	1.825	1.934
2500.401	1.778	1.755	0.022 ( +1.3% )	8.28	8.65	-4.4%	1.698	1.744
2500.402	2.794	2.771	0.022 ( +0.8% )	7.69	8.36	-7.9%	1.821	1.825
2500.403	5.103	5.081	0.022 ( +0.4% )	1.33	1.35	-1.6%	1.808	1.894
2500.404	2.802	2.779	0.022 ( +0.8% )	7.96	8.54	-6.8%	1.717	1.781
2500.5	4.936	4.936	0.000 ( +0.0% )	15.68	16.03	-2.2%	1.305	1.328
2500.51	8.960	8.960	0.000 ( +0.0% )	9.58	9.68	-1.1%	1.306	1.398

[vlimant]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[vlimant]

@bonanomi : please create the 14.0 backport PR for this feature

[namapane]

@bonanomi : please create the 14.0 backport PR for this feature

Done (#44654).

[antoniovilela]

+1