-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rivet 4.0.0 and YODA 2.0.0 #9111
Conversation
A new Pull Request was created by @mseidel42 for branch IB/CMSSW_14_1_X/master. @smuzaffar, @iarspider, @cmsbuild, @aandvalenzuela can you please review it and eventually sign? Thanks. |
cms-bot internal usage |
needs cms-sw/cmssw#44603 |
test parameters:
|
please test |
-1 Failed Tests: UnitTests RelVals RelVals-INPUT The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found 2 errors in the following unit tests: ---> test test-genParticles2HepMC had ERRORS ---> test test-rivet-plot had ERRORS RelVals
Expand to see more relval errors ...RelVals-INPUT |
Pull request #9111 was updated. |
These might be dictionary related errors but they seem transient? See discusison in cms-sw/cmssw#44603 (comment) Any ideas? :/ |
@mseidel42 , in the relval logs ( e.g. 135.4 ) I see errors like
could it be that we are missing |
or we now have |
Ah, just that one line or
as in hepmc_headers.xml? I added hepmc3 to GeneratorInterface/RivetInterface/BuildFile.xml, and Mikhail had it added to SimDataFormats/GeneratorProducts/BuildFile.xml already before :) |
just |
Pull request #9111 was updated. |
please test |
Hi Matti, thanks for checking! I see there are |
Updated cms-sw/cmssw#44603 so that the HepMC3Product now contains GenEventData instead of GenEvent. My local tests look fine... |
please test |
please test |
please test for el8_aarch64_gcc12 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c03f46/39608/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c03f46/39607/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c03f46/39627/summary.html Comparison SummarySummary:
|
Hi, would it be possible to proceed with this PR? Matti did not have any additional comments in the corresponding cms-sw/cmssw#44603 |
lets test cms-sw/cmssw#44603 and once that is approved/merged then we merge this PR too |
REMINDER @rappoccio, @sextonkennedy, @antoniovilela: This PR was tested with cms-sw/cmssw#44603, please check if they should be merged together |
cms-sw/cmssw#44603 has been merged so this should also get in to IB otherwise we will have broken IBs |
Right, thanks! 🙂 |
Requires HepMC3, HDF5, and ONNX now.
Announcement at https://rivet.hepforge.org/
CMSSW PR coming -> cms-sw/cmssw#44603