Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPP20] Remove references to deprecated std::is_pod #44651

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

iarspider
Copy link
Contributor

PR description:

std::is_pod is deprecated in C++20:

  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/799232d1e03caef2b7c55e82af01e207/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-04-05-1100/src/Alignment/Geners/interface/CPP11_type_traits.hh:8:27: warning: 'template<class _Tp> struct std::is_pod' is deprecated: use is_standard_layout && is_trivial instead [-Wdeprecated-declarations]
     8 | #define CPP11_is_pod std::is_pod
      |                           ^~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/799232d1e03caef2b7c55e82af01e207/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-04-05-1100/src/Alignment/Geners/interface/IOIsPOD.hh:11:20: note: in expansion of macro 'CPP11_is_pod'
   11 |     enum { value = CPP11_is_pod<T>::value };
      |                    ^~~~~~~~~~~~

PR validation:

Bot tests

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

cms-bot internal usage

@iarspider iarspider changed the title Remove references to deprecated std::is_pod [CPP20] Remove references to deprecated std::is_pod Apr 8, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44651/39850

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • Alignment/Geners (alca)

@saumyaphor4252, @consuegs, @perrotta can you please review it and eventually sign? Thanks.
@tocheng, @mmusich, @rsreds, @yuanchao, @adewit this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please test for CMSSW_14_1_CPP20_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d16fe/38670/summary.html
COMMIT: d86b146
CMSSW: CMSSW_14_1_CPP20_X_2024-04-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44651/38670/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d16fe/38670/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d16fe/38670/git-merge-result

Comparison Summary

Summary:

  • You potentially added 2377 lines to the logs
  • Reco comparison results: 120 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3307717
  • DQMHistoTests: Total failures: 505
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3307192
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 5 / 46 workflows

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d16fe/38669/summary.html
COMMIT: d86b146
CMSSW: CMSSW_14_1_X_2024-04-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44651/38669/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 20 lines to the logs
  • Reco comparison results: 41 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3307717
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3307691
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Apr 9, 2024

+1

  • Technical: it applies the suggested replacement

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@iarspider
Copy link
Contributor Author

@cms-sw/orp-l2 gentle ping

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3690033 into cms-sw:master Apr 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants