Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed pixelLayers requirement in MuonSelectors.cc #44692

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

fmanteca
Copy link
Contributor

PR description:

Removed pixelLayers requirement in loose muon Trigger ID to improve the efficiency for low pt muons.

HLT efficiency, rate, and timing estimates are given at https://its.cern.ch/jira/browse/CMSHLT-3079

PR validation:

https://its.cern.ch/jira/browse/CMSHLT-3079

@cmssw/hlt-l2

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44692/39896

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fmanteca for master.

It involves the following packages:

  • DataFormats/MuonReco (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@cericeci, @missirol, @trocino, @rovere, @abbiendi, @CeliaFernandez, @amagitte, @andrea21z, @Fedespring, @JanFSchulte, @jhgoh, @battibass, @HuguesBrun this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

assign hlt

@jfernan2
Copy link
Contributor

type muon

@cmsbuild
Copy link
Contributor

New categories assigned: hlt

@Martin-Grunewald,@mmusich you have been requested to review this Pull request/Issue and eventually sign? Thanks

@jfernan2
Copy link
Contributor

please test

@mmusich
Copy link
Contributor

mmusich commented Apr 10, 2024

unassign hlt

@mmusich
Copy link
Contributor

mmusich commented Apr 10, 2024

(but thanks for the tag)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17c2f3/38744/summary.html
COMMIT: f5aeab1
CMSSW: CMSSW_14_1_X_2024-04-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44692/38744/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 89 lines to the logs
  • Reco comparison results: 108 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3316263
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3316236
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@Martin-Grunewald
Copy link
Contributor

Please make a backport to 14_0.

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants