Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to merge the JSON files produced by the FastTimerService #44836

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Apr 24, 2024

PR description:

Add script to merge the content of multiple "resources.json" files produced by the FastTimerService, and print the result to standard output.

Usage: mergeResourceJson.py FILE [FILE ...]

Example:

mergeResourceJson.py step*/pid*/resources.json > resources.json

PR validation:

Tested producing 8 JSON files and merging them.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 14.0.x for data taking.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 24, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 24, 2024

please test

Even though there is nothing to test here.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44836/40081

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • HLTrigger/Timer (hlt)

@Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a51fa/39064/summary.html
COMMIT: 96f98b2
CMSSW: CMSSW_14_1_X_2024-04-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44836/39064/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a51fa/39064/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a51fa/39064/git-merge-result

Comparison Summary

Summary:

  • You potentially added 21 lines to the logs
  • Reco comparison results: 58 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3319852
  • DQMHistoTests: Total failures: 16
  • DQMHistoTests: Total nulls: 195
  • DQMHistoTests: Total successes: 3319621
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3605.085 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 127.810 KiB JetMET/MET
  • DQMHistoSizes: changed ( 1000.0 ): 43.835 KiB JetMET/Jet
  • DQMHistoSizes: changed ( 10224.0,... ): 43.851 KiB JetMET/Jet
  • DQMHistoSizes: changed ( 13234.0,... ): 0.016 KiB JetMET/Jet
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Apr 24, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 71fd94c into cms-sw:master Apr 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants