Using explicit lazy parsing & concrete data types in SimpleFlatTableProducer #44782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The T0 had a failure from the string parser which we have previously attributed to using the lazy option of the string parser. Added option to turn on lazy parsing from the configuration. This is an 'opt' in since lazy parsing can be problematic so best to explicitly state it must be used.
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44782/40016
|
|
A new Pull Request was created by @hqucms for master. It involves the following packages:
@vlimant, @cmsbuild, @hqucms, @saumyaphor4252, @perrotta, @jfernan2, @mandrenguyen, @consuegs can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
enable nano |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ec77b/38946/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
|
+1 |
|
+alca
|
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ec77b/39012/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
xpog-approved
and removed
pending-signatures
xpog-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This was referenced Apr 24, 2024
Merged
|
@cms-sw/xpog-l2 @hqucms We need a quick fix for 14_1_X and 14_0_X for the ProductNotFound error in RelVals: |
|
looks like unrelated to this PR ; what else has gone in that IB ? |
|
The list of PRs added to that build can be found here |
|
@vlimant it could be this PR if the type of the data product now being asked for by the module does not actually match the type in the edm::Event. |
|
indeed, the type is |
This was referenced Apr 25, 2024
|
Fixes here: |
|
Given the values being used in the cut string, just using |
yes that's what I did :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Building on the implementation by @Dr15Jones in #44575 and some discussions there, I modified the usage of
SimpleFlatTableProducerto read concrete data types instead of the basereco::Candidate. This avoids the large number oflazyEval = Truepreviously needed in #44575.PR validation:
Tested for all NANO workflows: