Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metMCTable in NanoGEN #44850

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Apr 25, 2024

PR description:

Fixes the ProductNotFound error in relval wf 546.0, as reported in #44782 (comment).

Cause of the error: In we changed metMCTable to take input of the specific pat::MET type. However, in the NanoGEN customization, the input is changed to genMetTrue which is of a different type (reco::MET), thus the ProductNotFound error.

PR validation:

runTheMatrix.py -l 546.0,547.0,548.0 --ibeos

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 25, 2024

cms-bot internal usage

@hqucms
Copy link
Contributor Author

hqucms commented Apr 25, 2024

enable nano

@hqucms
Copy link
Contributor Author

hqucms commented Apr 25, 2024

please test workflow 546.0,547.0,548.0

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44850/40102

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hqucms for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@hqucms, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d73a8/39106/summary.html
COMMIT: c97b0e5
CMSSW: CMSSW_14_1_X_2024-04-25-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44850/39106/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 80 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 48 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3326929
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3326903
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 210 log files, 173 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 17023
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 17023
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 55 log files, 32 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.783 2.783 0.000 ( +0.0% ) 3.45 3.55 -2.7% 2.146 2.117
2500.001 2.897 2.897 0.000 ( +0.0% ) 3.09 3.15 -2.0% 2.555 2.135
2500.002 2.843 2.843 0.000 ( +0.0% ) 3.10 3.31 -6.3% 2.522 2.146
2500.01 1.446 1.446 0.000 ( +0.0% ) 5.90 6.11 -3.5% 2.312 1.994
2500.011 1.906 1.906 0.000 ( +0.0% ) 3.24 3.34 -3.0% 2.484 2.005
2500.012 1.761 1.761 0.000 ( +0.0% ) 4.67 4.60 +1.6% 2.379 2.114
2500.1 2.354 2.354 0.000 ( +0.0% ) 4.41 4.60 -4.1% 1.953 2.054
2500.2 2.459 2.459 0.000 ( +0.0% ) 5.04 5.26 -4.2% 1.860 1.941
2500.21 1.286 1.286 0.000 ( +0.0% ) 3.40 3.53 -3.7% 2.130 1.951
2500.211 1.668 1.668 0.000 ( +0.0% ) 3.08 3.28 -5.9% 2.178 1.941
2500.3 2.229 2.229 0.000 ( +0.0% ) 9.42 10.00 -5.9% 1.854 1.974
2500.301 2.833 2.833 0.000 ( +0.0% ) 8.61 8.80 -2.2% 1.795 1.956
2500.31 7.164 7.164 0.000 ( +0.0% ) 1.48 1.48 -0.0% 1.707 1.702
2500.311 1.568 1.568 0.000 ( +0.0% ) 8.49 7.89 +7.5% 1.056 1.051
2500.312 540.457 540.457 0.000 ( +0.0% ) 0.51 0.54 -5.4% 1.593 1.623
2500.313 817.694 817.694 0.000 ( +0.0% ) 0.72 0.75 -4.0% 1.591 1.596
2500.32 1.348 1.348 0.000 ( +0.0% ) 12.19 12.85 -5.1% 2.200 1.755
2500.321 1.757 1.757 0.000 ( +0.0% ) 10.45 10.84 -3.6% 2.411 1.947
2500.322 1.236 1.236 0.000 ( +0.0% ) 9.96 10.72 -7.1% 2.158 2.130
2500.323 7.772 7.772 0.000 ( +0.0% ) 3.84 4.31 -11.0% 1.916 1.826
2500.324 1.874 1.874 0.000 ( +0.0% ) 10.00 10.80 -7.4% 2.150 2.178
2500.325 4.136 4.136 0.000 ( +0.0% ) 4.39 4.69 -6.4% 2.156 2.168
2500.326 3.342 3.342 0.000 ( +0.0% ) 1.61 1.70 -5.0% 2.086 2.120
2500.327 1.811 1.811 0.000 ( +0.0% ) 10.20 11.05 -7.8% 2.162 2.299
2500.4 2.374 2.374 0.000 ( +0.0% ) 9.01 9.46 -4.8% 1.798 1.824
2500.401 1.891 1.891 0.000 ( +0.0% ) 8.16 8.65 -5.6% 1.694 1.684
2500.402 2.950 2.950 0.000 ( +0.0% ) 8.15 8.57 -5.0% 1.742 1.756
2500.403 8.700 8.700 0.000 ( +0.0% ) 2.92 3.13 -6.6% 1.753 1.792
2500.404 5.474 5.474 0.000 ( +0.0% ) 1.11 1.23 -9.4% 1.808 1.808
2500.405 2.860 2.860 0.000 ( +0.0% ) 8.15 8.75 -7.0% 1.745 1.779
2500.5 5.194 5.194 0.000 ( +0.0% ) 15.64 16.42 -4.8% 1.525 1.521
2500.51 9.120 9.120 0.000 ( +0.0% ) 9.54 9.89 -3.5% 1.472 1.472

@antoniovilela
Copy link
Contributor

+orp

  • Will be merged with XPOG signature.

@hqucms
Copy link
Contributor Author

hqucms commented Apr 25, 2024

+xpog

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 768d4e6 into cms-sw:master Apr 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants