Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undeclared identifiers in RectangularPixelPhase2Topology #45038

Merged
merged 1 commit into from
May 28, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -83,16 +83,17 @@ std::pair<float, float> RectangularPixelPhase2Topology::pixel(const LocalPoint&
if (iybin0 > m_COLS_PER_ROC) {
LogDebug("RectangularPixelPhase2Topology") << " very bad, newbiny " << iybin0 << "\n"
<< py << " " << m_yoffset << " " << m_pitchy << " " << newybin << " "
<< iybin << " " << fractionY << " " << iybin0 << " " << numROC;
<< iybin << " " << fractionY << " " << iybin0 << " " << m_COLS_PER_ROC;
}
#endif // EDM_ML_DEBUG

#ifdef EDM_ML_DEBUG

if (mpY < 0. || mpY >= 2 * m_COLS_PER_ROC) {
LogDebug("RectangularPixelPhase2Topology") << " bad pix y " << mpY << "\n"
<< py << " " << m_yoffset << " " << m_pitchy << " " << newybin << " "
<< iybin << " " << fractionY << " " << iybin0 << " " << numROC;
LogDebug("RectangularPixelPhase2Topology")
<< " bad pix y " << mpY << "\n"
<< py << " " << m_yoffset << " " << m_pitchy << " " << newybin << " " << iybin << " " << fractionY << " "
<< iybin0 << " " << 2 * m_COLS_PER_ROC;
}
#endif // EDM_ML_DEBUG

Expand Down Expand Up @@ -130,7 +131,7 @@ std::pair<float, float> RectangularPixelPhase2Topology::pixel(const LocalPoint&

#ifdef EDM_ML_DEBUG

if (ixbin0 > m_ROW_PER_ROC || ixbin0 < 0) // ixbin < 0 outside range
if (ixbin0 > m_ROWS_PER_ROC || ixbin0 < 0) // ixbin < 0 outside range
{
LogDebug("RectangularPixelPhase2Topology")
<< " very bad, newbinx " << ixbin << "\n"
Expand All @@ -140,7 +141,7 @@ std::pair<float, float> RectangularPixelPhase2Topology::pixel(const LocalPoint&

#ifdef EDM_ML_DEBUG

if (mpX < 0. || mpX >= 2 * m_ROW_PER_ROC) {
if (mpX < 0. || mpX >= 2 * m_ROWS_PER_ROC) {
LogDebug("RectangularPixelPhase2Topology")
<< " bad pix x " << mpX << "\n"
<< px << " " << m_xoffset << " " << m_pitchx << " " << newxbin << " " << ixbin << " " << fractionX;
Expand Down