Fix undeclared identifiers in RectangularPixelPhase2Topology

[iarspider]

PR description:

Fix compilation errors in DBG_X IB:

  src/Geometry/TrackerGeometryBuilder/src/RectangularPixelPhase2Topology.cc:86:104: error: 'numROC' was not declared in this scope
    86 |                                                << iybin << " " << fractionY << " " << iybin0 << " " << numROC;
      |                                                                                                        ^~~~~~
  src/Geometry/TrackerGeometryBuilder/src/RectangularPixelPhase2Topology.cc:95:104: error: 'numROC' was not declared in this scope
    95 |                                                << iybin << " " << fractionY << " " << iybin0 << " " << numROC;
      |                                                                                                        ^~~~~~
  src/Geometry/TrackerGeometryBuilder/src/RectangularPixelPhase2Topology.cc:133:16: error: 'm_ROW_PER_ROC' was not declared in this scope; did you mean 'm_ROWS_PER_ROC'?
   133 |   if (ixbin0 > m_ROW_PER_ROC || ixbin0 < 0)  //  ixbin < 0 outside range
      |                ^~~~~~~~~~~~~
      |                m_ROWS_PER_ROC
  src/Geometry/TrackerGeometryBuilder/src/RectangularPixelPhase2Topology.cc:143:30: error: 'm_ROW_PER_ROC' was not declared in this scope; did you mean 'm_ROWS_PER_ROC'?
   143 |   if (mpX < 0. || mpX >= 2 * m_ROW_PER_ROC) {
      |                              ^~~~~~~~~~~~~
      |                              m_ROWS_PER_ROC

PR validation:

Bot tests

[iarspider]

please test for CMSSW_14_1_DBG_X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45038/40337

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45038/40337/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45038/40337/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[iarspider]

please test for CMSSW_14_1_DBG_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45038/40338

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• Geometry/TrackerGeometryBuilder (geometry)

@makortel, @civanch, @mdhildreth, @Dr15Jones, @bsunanda can you please review it and eventually sign? Thanks.
@JanFSchulte, @VinInn, @fabiocos, @mtosi, @venturia, @mmusich, @VourMa, @bsunanda this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3cc08/39511/summary.html
COMMIT: 9ed4c70
CMSSW: CMSSW_14_1_DBG_X_2024-05-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45038/39511/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 5 errors in the following unit tests:

---> test test_MC_22_crosscheck had ERRORS
---> test test_MC_23_crosscheck had ERRORS
---> test test_MC_23_setup had ERRORS
and more ...

RelVals

• 4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log
• 4.534.53_RunPhoton2012B/step2_RunPhoton2012B.log
• 5.15.1_TTbarFS/step1_TTbarFS.log

Expand to see more relval errors ...

• 7.3
• 8.0
• 9.0
• 25.0
• 135.4
• 136.731
• 136.7611
• 136.793
• 136.8311
• 136.874
• 136.88811
• 139.001
• 140.023
• 140.043
• 140.063
• 140.56
• 1306.0
• 158.01
• 141.044
• 141.042
• 1330.0
• 101.0
• 141.046
• 312.0
• 25202.0
• 1000.0
• 1001.0
• 10224.0
• 11634.0
• 12434.0
• 12834.0
• 12834.7
• 12846.0
• 13034.0
• 13234.0
• 14034.0
• 14234.0
• 23234.0
• 24834.0
• 24834.911
• 24896.0
• 24900.0
• 25034.999
• 250202.181
• 2500.4

AddOn Tests

• fastsim

[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 1 sec (ended on Fri May 24 12:18:24 2024) - exit: 256

• fastsim1

[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 1 sec (ended on Fri May 24 12:18:25 2024) - exit: 256

• fastsim2

[fastsim2:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - elapsed time: 1 sec (ended on Fri May 24 12:18:26 2024) - exit: 256

Expand to see more addon errors ...

• pat1
• hlt_mc_Fake
• hlt_mc_Fake
• hlt_mc_Fake
• hlt_mc_Fake1
• hlt_mc_Fake1
• hlt_mc_Fake1
• hlt_mc_Fake2
• hlt_mc_Fake2
• hlt_mc_Fake2
• hlt_mc_GRun
• hlt_mc_GRun
• hlt_mc_GRun
• hlt_mc_HIon
• hlt_mc_HIon
• hlt_mc_HIon
• hlt_mc_PIon
• hlt_mc_PIon
• hlt_mc_PIon
• hlt_mc_PRef
• hlt_mc_PRef
• hlt_mc_PRef
• hlt_mc_Special
• hlt_mc_Special
• hlt_mc_Special
• hlt_data_Fake
• hlt_data_Fake
• hlt_data_Fake
• hlt_data_Fake1
• hlt_data_Fake1
• hlt_data_Fake1
• hlt_data_Fake2
• hlt_data_Fake2
• hlt_data_Fake2
• hlt_data_GRun
• hlt_data_GRun
• hlt_data_GRun
• hlt_data_HIon
• hlt_data_HIon
• hlt_data_HIon
• hlt_data_PIon
• hlt_data_PIon
• hlt_data_PIon
• hlt_data_PRef
• hlt_data_PRef
• hlt_data_PRef
• hlt_data_Special
• hlt_data_Special
• hlt_data_Special

[iarspider]

please test for CMSSW_14_1_X
just in case

[iarspider]

Failed Tests: UnitTests RelVals AddOn **

The compilation errors are gone, and the failures are expected (since base release was broken due to errors)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3cc08/39514/summary.html
COMMIT: 9ed4c70
CMSSW: CMSSW_14_1_X_2024-05-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45038/39514/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338839
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

the fix seems to be transparent. What is not clear to me: bot approve test results with unit tests falling.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1