[14.0.X] skip bad channels in PFRecHitProducerKernelConstruct<T>::applyCuts

[mmusich]

backport of #45604

PR description:

This PR is a simple fix for #45595 and implements the suggestion at #45595 (comment)
Skips bad channels in PFRecHitProducerKernelConstruct<T>::applyCuts

• as implemented in HcalRecHitSoAToLegacy
• also check denseId validity before retrieving the corresponding PF threshold

PR validation:

Run successfully the reproducer script at #45595 (comment).

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #45604 to the 2024 data-taking release cycle

[mmusich]

type pf

[cmsbuild]

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

• RecoParticleFlow/PFRecHitProducer (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@hatakeyamak, @lgray, @missirol, @mmarionncern, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from skip bad channels in PFRecHitProducerKernelConstruct<T>::applyCuts #45604

[cmsbuild]

cms-bot internal usage

[mandrenguyen]

urgent
Patch needed for data taking IIUC

[mandrenguyen]

type bug-fix

[mandrenguyen]

please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8834c2/40708/summary.html
COMMIT: bc2c4d9
CMSSW: CMSSW_14_0_X_2024-07-31-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45611/40708/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 74 lines to the logs
• Reco comparison results: 66 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3343220
• DQMHistoTests: Total failures: 1215
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3341985
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1