Another workaround for -O3 ASAN compilation issue in CTPPSProtonReconstructionPlotter

[makortel]

PR description:

Build of CMSSW_14_1_ASAN_X_2024-08-21-2300 failed with

In file included from src/DataFormats/Common/interface/RefVector.h:18,
                 from src/DataFormats/ProtonReco/interface/ForwardProton.h:14,
                 from src/Validation/CTPPS/plugins/CTPPSProtonReconstructionPlotter.cc:20:
In member function 'edm::RefVectorIterator<C, T, F>::reference edm::RefVectorIterator<C, T, F>::operator*() const [with C = std::vector<CTPPSLocalTrackLite>; T = CTPPSLocalTrackLite; F = edm::refhelper::FindUsingAdvance<std::vector<CTPPSLocalTrackLite>, CTPPSLocalTrackLite>]',
    inlined from 'virtual void CTPPSProtonReconstructionPlotter::analyze(const edm::Event&, const edm::EventSetup&)' at src/Validation/CTPPS/plugins/CTPPSProtonReconstructionPlotter.cc:627:22:
  src/DataFormats/Common/interface/RefVectorIterator.h:49:39: error: 'this' pointer is null [-Werror=nonnull]
    49 |       return (*nestedRefVector_)[iter_];
      |                                       ^
src/DataFormats/Common/interface/RefVector.h: In member function 'virtual void CTPPSProtonReconstructionPlotter::analyze(const edm::Event&, const edm::EventSetup&)':
src/DataFormats/Common/interface/RefVector.h:70:22: note: in a call to non-static member function 'const edm::RefVector<C, T, F>::value_type edm::RefVector<C, T, F>::operator[](size_type) const [with C = edm::RefVector<std::vector<CTPPSLocalTrackLite> >; T = CTPPSLocalTrackLite; F = edm::refhelper::FindRefVectorUsingAdvance<edm::RefVector<std::vector<CTPPSLocalTrackLite> > >]'
   70 |     value_type const operator[](size_type idx) const {
      |                      ^~~~~~~~
In member function 'edm::RefVectorIterator<C, T, F>::reference edm::RefVectorIterator<C, T, F>::operator*() const [with C = std::vector<CTPPSLocalTrackLite>; T = CTPPSLocalTrackLite; F = edm::refhelper::FindUsingAdvance<std::vector<CTPPSLocalTrackLite>, CTPPSLocalTrackLite>]',
    inlined from 'virtual void CTPPSProtonReconstructionPlotter::analyze(const edm::Event&, const edm::EventSetup&)' at src/Validation/CTPPS/plugins/CTPPSProtonReconstructionPlotter.cc:725:24:
  src/DataFormats/Common/interface/RefVectorIterator.h:49:39: error: 'this' pointer is null [-Werror=nonnull]
    49 |       return (*nestedRefVector_)[iter_];
      |                                       ^
src/DataFormats/Common/interface/RefVector.h: In member function 'virtual void CTPPSProtonReconstructionPlotter::analyze(const edm::Event&, const edm::EventSetup&)':
src/DataFormats/Common/interface/RefVector.h:70:22: note: in a call to non-static member function 'const edm::RefVector<C, T, F>::value_type edm::RefVector<C, T, F>::operator[](size_type) const [with C = edm::RefVector<std::vector<CTPPSLocalTrackLite> >; T = CTPPSLocalTrackLite; F = edm::refhelper::FindRefVectorUsingAdvance<edm::RefVector<std::vector<CTPPSLocalTrackLite> > >]'
   70 |     value_type const operator[](size_type idx) const {
      |                      ^~~~~~~~
cc1plus: some warnings being treated as errors

which is the same error as noted in #44931 (comment) and worked around in #44931 (comment) and #45304. This PR applies the same workaround to other part in this code.

Resolves cms-sw/framework-team#1004

PR validation:

Code compiles in CMSSW_14_1_ASAN_X_2024-08-21-2300

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45786/41516

[cmsbuild]

A new Pull Request was created by @makortel for master.

It involves the following packages:

• Validation/CTPPS (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@grzanka, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[makortel]

FYI @dan131riley

[makortel]

@cmsbuild, please test

[makortel]

@cmsbuild, please test for CMSSW_14_1_ASAN_X

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38fea8/41106/summary.html
COMMIT: b054169
CMSSW: CMSSW_14_1_ASAN_X_2024-08-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45786/41106/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS
---> test test_MC_23_setup had ERRORS

[makortel]

The unit test failure in ASAN is tracked in #45751

[makortel]

@cmsbuild, please test

Let's (re-)run the normal tests too

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38fea8/41135/summary.html
COMMIT: b054169
CMSSW: CMSSW_14_1_X_2024-08-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45786/41135/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 2024.0010012024.001001_RunZeroBias2024D_10k/step1_dasquery.log
• 2024.0000012024.000001_RunJetMET02024D_10k/step1_dasquery.log
• 2024.000001DAS Error

Expand to see more relval errors ...

• 2024.001001

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 81 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3328202
• DQMHistoTests: Total failures: 4594
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3323588
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

[iarspider]

@cmsbuild ignore tests-rejected with ib-failure

[makortel]

@cms-sw/dqm-l2 Could you please review and sign? Thanks!