Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request #6059 with a fix to memory handling #6175

Merged
merged 5 commits into from
Nov 3, 2014

Conversation

mark-grimes
Copy link

This is pull request #6059 with one small change to initialise a pointer to null. Otherwise under certain conditions the destructor will delete a random memory location. It was causing very bizarre crashes, I'd post the stack trace but since it affects a random memory location I don't think it's relevant.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2014

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Pull request #6059 with a fix to memory handling

It involves the following packages:

CalibCalorimetry/HcalPlugins
DataFormats/HcalCalibObjects
SLHCUpgradeSimulations/Configuration
SimCalorimetry/HcalSimProducers
SimG4CMS/Calo
SimG4Core/Application

@civanch, @nclopezo, @mdhildreth, @cmsbuild, @diguida, @rcastello, @cerminar, @mmusich can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link
Author

merge

cmsbuild added a commit that referenced this pull request Nov 3, 2014
Pull request #6059 with a fix to memory handling
@cmsbuild cmsbuild merged commit 7032960 into cms-sw:CMSSW_6_2_X_SLHC Nov 3, 2014
@mark-grimes mark-grimes deleted the fix6059 branch November 3, 2014 16:42
@kpedro88
Copy link
Contributor

kpedro88 commented Nov 3, 2014

Thanks for fixing this bug, Mark! That was my fault.

@mark-grimes
Copy link
Author

No worries, these things happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants