Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of HLTDeDxFilter for 72X #6287

Merged
merged 1 commit into from
Nov 11, 2014

Conversation

Martin-Grunewald
Copy link
Contributor

Fix of HLTDeDxFilter for 72X
Do not get the collection if it is not used.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2014

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_2_X.

Fix of HLTDeDxFilter for 72X

It involves the following packages:

RecoTracker/DeDx

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @gpetruc, @cerati, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@StoyanStoynev
Copy link
Contributor

@cmsbuild please test

@StoyanStoynev
Copy link
Contributor

I want to see the jenkins results before signing off.
I would also like to see a bit more of a description - not a copy of the subject (doesn't improve our documentation).
I tested 83bbe32 on top of CMSSW_7_2_X_2014-11-08-0200 - short matrix tests,, FWLite + DQM comparisons. No diffs in the monitored quantities and none expected. No issues for RECO.

@StoyanStoynev
Copy link
Contributor

@cmsbuild please test

@Martin-Grunewald
Copy link
Contributor Author

@nclopezo can you please check why tests are not run on this PR?

@StoyanStoynev
Copy link
Contributor

+1
For 83bbe32 .
Based on the tests above and on the jenkins results in #6288 (identical PR for 73X) - no diffs and none expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @nclopezo, @ktf, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @nclopezo, @ktf, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @nclopezo, @ktf, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants