Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of HLTDeDxFilter for 73X #6288

Merged
merged 1 commit into from
Nov 10, 2014

Conversation

Martin-Grunewald
Copy link
Contributor

Fix of HLTDeDxFilter for 73X
Do not get the collection if it is not used.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2014

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_3_X.

Fix of HLTDeDxFilter for 73X

It involves the following packages:

RecoTracker/DeDx

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @gpetruc, @cerati, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@StoyanStoynev
Copy link
Contributor

@cmsbuild please test

@StoyanStoynev
Copy link
Contributor

Identical to #6287 - see there to see what's holding it.

@StoyanStoynev
Copy link
Contributor

@cmsbuild please test

@Martin-Grunewald
Copy link
Contributor Author

@nclopezo can you please check why tests are not run on this PR?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

+1
For 334d77a .
Based on jenkins and tests in #6287 (which is identical PR but for 72X) - no diffs and none expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants