Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments for using MixingModule for Heavy Ion simulations #6982

Merged
merged 61 commits into from Jan 16, 2015

Conversation

yetkinyilmaz
Copy link
Contributor

This is the minimum updates in order to be able to run MixingModule for Heavy-Ion embedding studies.
Presented in https://indico.cern.ch/event/344150/

The main difference from pp pile-up simulations is that it runs mixing in gen-level, and the sim-level mixing in next process happens in playback mode. Event contents are updated accordingly. ConfigBuilder is adjusted so that the commands here define the workflows successfully:
https://github.com/CmsHI/cmssw/blob/mix_74X_08/HeavyIonsAnalysis/Mixing/test/runChainTemp.sh

Tested on
slc6_amd64_gcc491
by
runTheMatrix.py -s --useInput all
runTheMatrix.py -l 140.53

To be followed up in later pull-requests:

  • Clean up ConfigBuilder.py, StandardSequences other configs for left-overs form the old heavy-ion embedding workflow
  • Define the RelVal workflows
  • Update PyquenInterface also for the ability to read background event information (special embedding features of Pyquen are temporarily disabled)
  • Update in PlaybackInfo dataformat to keep file info - independent development

@yetkinyilmaz
Copy link
Contributor Author

merging?

davidlange6 added a commit that referenced this pull request Jan 16, 2015
Adjustments for using MixingModule for Heavy Ion simulations
@davidlange6 davidlange6 merged commit 21d9bf4 into cms-sw:CMSSW_7_4_X Jan 16, 2015
@yetkinyilmaz
Copy link
Contributor Author

This is totally expected, but I should have temporarily disabled these workflows in the PR. The new methods are completely different, so these workflows will have to be almost completely written from scratch - cleaning the old style HiMixingModule related stuff (see the PR description).
Can we exclude these workflows from the RelVal temporarily, reserving the numbers associated to them to be used for the updated versions?

@yetkinyilmaz
Copy link
Contributor Author

Just answered in the sw thread, yes, we will PR a fix soon.

On 1/19/15 11:42 AM, Martin Grunewald wrote:

Hi,

This PR seems to break our addON HLT/HIon test, see here:

https://cmssdt.cern.ch/SDT/cgi-bin//showAddOnLogs.py/slc6_amd64_gcc491/www/sun/7.4-sun-02/CMSSW_7_4_X_2015-01-18-0200/addOnTests/

specifically the test:

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc481/CMSSW_7_4_X_2015-01-16-1400/addOnTests/logs/cmsDriver-hlt_mc_HIon_cmsDriver.py_TTbar_Tauola_13TeV_cfi_-s_GEN,SIM,DIGI,L1,DIGI2RAW_--mc_--scenario=HeavyIons_-n_10_--conditions_auto:run2_mc_HIon_--relval_9000,50_--data.log

Can you please have a look and suggest a fix?
Thanks!


Reply to this email directly or view it on GitHub
#6982 (comment).

@franzoni
Copy link

Hello @yetkinyilmaz ,
in this big PR, the file: in Configuration/StandardSequences/python/VtxSmeared.py
the line: 'RealisticHI2011Collision':

'IOMC.EventVertexGenerators.VtxSmearedRealisticHI2011Collision_cfi',

has been removed which holds the default SIM beam-spot for heavy ion (as verbally agreed at the orp wtih @mandrenguyen, see also the discussion in #6751).

Removing that line breaks the consistency of VtxSmeared.py . The breaking was not detected by tests which recycle the GEN-SIM for HI. 7_4_0_pre5 still had the line => re-doing the GEN-SIM relval was ok. The first release w/o the line is 7_4_0_pre5_ROOT6, and the subsequent IB's.

Why was the line removed ? Any change in LHC BS expectations for HI run2?
Please let's clarify and make sure we get things right in relation also to #7288.

@yetkinyilmaz
Copy link
Contributor Author

Hi Giovanni,
this was a mistake.
we will commit the fix along with some other fixes in the currently open PR:
#7287

On 1/20/15 11:11 PM, Giovanni Franzoni wrote:

Hello @yetkinyilmaz https://github.com/yetkinyilmaz ,
in this big PR, the file: in
Configuration/StandardSequences/python/VtxSmeared.py
the line: 'RealisticHI2011Collision':

'IOMC.EventVertexGenerators.VtxSmearedRealisticHI2011Collision_cfi',

has been removed which holds the default SIM beam-spot for heavy ion
(as verbally agreed at the orp wtih @mandrenguyen
https://github.com/mandrenguyen, see also the discussion in #6751
#6751).

Removing that line breaks the consistency of VtxSmeared.py . The
breaking was not detected by tests which recycle the GEN-SIM for HI.
7_4_0_pre5 still had the line => re-doing the GEN-SIM relval was ok.
The first release w/o the line is 7_4_0_pre5_ROOT6, and the subsequent
IB's.

Why was the line removed ? Any change in LHC BS expectations for HI run2?
Please let's clarify and make sure we get things right in relation
also to #7288 #7288.


Reply to this email directly or view it on GitHub
#6982 (comment).

@franzoni
Copy link

Thanks, @yetkinyilmaz.
If you're sure #7287 can be in pre6 => good as you say.
Otherwise, we can put it back as a standalone. I would not want to have a matrix in pre6 uncapable of re-doing gen-sim for HI.
@ktf @davidlange6 can you please take note, in relation to the pre6 schedule ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet