Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes and clean-up after HI mixing updates #7287

Merged
merged 96 commits into from
Jan 27, 2015

Conversation

yetkinyilmaz
Copy link
Contributor

Follow-up on:
#6982

fixing/excluding failed workflows
clean up of obsolete HiMixingModule related options/configurations/products
uniformization of genParticle collection and sequence names

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @yetkinyilmaz for CMSSW_7_4_X.

Bugfixes and clean-up after HI mixing updates

It involves the following packages:

Configuration/Applications
Configuration/PyReleaseValidation
Configuration/StandardSequences
PhysicsTools/HepMCCandAlgos
RecoHI/HiJetAlgos
RecoJets/Configuration
SimGeneral/MixingModule

@civanch, @nclopezo, @cvuosalo, @boudoul, @franzoni, @mdhildreth, @monttj, @cmsbuild, @srimanob, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @rappoccio, @yslai, @TaiSakuma, @Martin-Grunewald, @makortel, @dgulhan, @cerati, @mandrenguyen, @wmtan, @GiacomoSguazzoni, @rovere, @VinInn, @nhanvtran, @schoef, @richard-cms, @jazzitup, @appeltel, @ahinzmann, @yenjie, @kurtejung, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@yetkinyilmaz
Copy link
Contributor Author

I did, can you have a look?
Thanks.

On 1/26/15 7:58 PM, David Lange wrote:

@yetkinyilmaz https://github.com/yetkinyilmaz - seems this PR no
longer merges - could you rebase?


Reply to this email directly or view it on GitHub
#7287 (comment).

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

naively looks not ok - but I'll check again once we have an IB/release candidate with everything that just changed.

@davidlange6
Copy link
Contributor

@yetkinyilmaz - now that I have a current IB available, your rebase is fine. I'm merging as this was signed already

davidlange6 added a commit that referenced this pull request Jan 27, 2015
Bugfixes and clean-up after HI mixing updates
@davidlange6 davidlange6 merged commit 29d3123 into cms-sw:CMSSW_7_4_X Jan 27, 2015
@harmonicoscillator harmonicoscillator deleted the mix_74X_11 branch December 11, 2015 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment