Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for L1 problems observed in 74X FastSim #7391

Merged
merged 1 commit into from Jan 28, 2015

Conversation

Martin-Grunewald
Copy link
Contributor

This PR should fix, for 74X, the L1T-FastSim issues reported here:
https://hypernews.cern.ch/HyperNews/CMS/get/relval/3378.html

(The 73X PR is #7390)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_4_X.

Fix for L1 problems observed in 74X FastSim

It involves the following packages:

FastSimulation/HighLevelTrigger
HLTrigger/Configuration
L1Trigger/L1TCommon

@perrotta, @cmsbuild, @civanch, @nclopezo, @lveldere, @mdhildreth, @Martin-Grunewald, @fwyzard, @mulhearn can you please review it and eventually sign? Thanks.
@matt-komm, @geoff-smith, @jalimena this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@Martin-Grunewald
Copy link
Contributor Author

+1

Works fine in CMSSW_7_4_X_2015-01-27-0200 plus PRs #7287 #7370 #7381 #7391

@lveldere
Copy link
Contributor

+1

@Martin-Grunewald
Copy link
Contributor Author

@mulhearn
Can you please sign this PR: it is the 74X equivalent of the 73X PR #7390 which you have signed already!

@mulhearn
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 28, 2015
Fix for L1 problems observed in 74X FastSim
@cmsbuild cmsbuild merged commit cb7bdf8 into cms-sw:CMSSW_7_4_X Jan 28, 2015
@Martin-Grunewald Martin-Grunewald deleted the FixForFastSimL174X branch January 29, 2015 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants