Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to JetCorrectorParametersCollection compatibility DB object #7907

Closed
wants to merge 2 commits into from

Conversation

yslai
Copy link

@yslai yslai commented Feb 23, 2015

Change to utilize the HIN Voronoi DB object in the "compatibility format", which is itself a JetCorrectorParametersCollection. Per discussion on Feb. 19, this change is done simultaneously to the Dropbox upload of the corresponding DB objects.

However, I am not sure whether RelVal will be successful, if there is no new Global Tag (currently being requested).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @yslai for CMSSW_7_4_X.

Switch to JetCorrectorParametersCollection compatibility DB object

It involves the following packages:

RecoHI/HiJetAlgos

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@jazzitup, @dgulhan, @appeltel, @yenjie, @kurtejung, @mandrenguyen, @richard-cms, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Feb 23, 2015

@cmsbuild please test

Yu Shi, please put some details in the PR description, specifically if changes are expected.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: 9ff6800
When I ran the RelVals I found an error in the following worklfows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
----- Begin Fatal Exception 23-Feb-2015 18:08:35 CET-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 182124 lumi: 40 event: 1893722
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module VoronoiBackgroundProducer/'voronoiBackgroundCalo'
Exception Message:
No data of type "JetCorrectorParametersCollection" with label "UETableCompatibilityFormat_Calo_v00_mc" in record "JetCorrectionsRecord"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7907/2837/summary.html

@slava77
Copy link
Contributor

slava77 commented Mar 4, 2015

was the last change actually supposed to fix this PR?
I see that jenkins tests in 140.53 already failed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2015

-1
Tested at: 0eccfed
When I ran the RelVals I found an error in the following worklfows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
----- Begin Fatal Exception 04-Mar-2015 22:52:34 CET-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 182124 lumi: 40 event: 1893722
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module VoronoiBackgroundProducer/'voronoiBackgroundCalo'
Exception Message:
No data of type "JetCorrectorParametersCollection" with label "UETable_Calo" in record "JetCorrectionsRecord"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7907/3119/summary.html

@yetkinyilmaz
Copy link
Contributor

The test appears to be with

--conditions auto:run1_data

which may be the problem. How should this be fixed?

On 3/4/15 11:36 PM, cmsbuild wrote:

-1
Tested at: 0eccfed
0eccfed
When I ran the RelVals I found an error in the following worklfows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

----- Begin Fatal Exception 04-Mar-2015 22:52:34 CET-----------------------

An exception of category 'NoProxyException' occurred while

[0] Processing run: 182124 lumi: 40 event: 1893722

[1] Running path 'reconstruction_step'

[2] Calling event method for module VoronoiBackgroundProducer/'voronoiBackgroundCalo'

Exception Message:

No data of type "JetCorrectorParametersCollection" with label "UETable_Calo" in record "JetCorrectionsRecord"

Please add an ESSource or ESProducer to your job which can deliver this data.

----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7907/3119/summary.html


Reply to this email directly or view it on GitHub
#7907 (comment).

@slava77
Copy link
Contributor

slava77 commented Mar 4, 2015

The jobs are running on run-1 HI data. So, the GT choice is correct.
The payloads are not in available global tags apparently.
Were the requests submitted as suggested by Salvatore #7907 (comment)
?

@diguida
Copy link
Contributor

diguida commented Mar 5, 2015

@slava77 @yetkinyilmaz
I discussed with @yslai and the requests are ok. The PR for GT is being prepared.

@slava77
Copy link
Contributor

slava77 commented Mar 11, 2015

Hi Salvatore,
I just wanted to check if GT is coming.
Please clarify/confirm if it will be in 74X or just in 75X?
If only in 75X, then this PR should be moved to 75X only (and closed here in the 74X branch).

@diguida
Copy link
Contributor

diguida commented Mar 11, 2015

@slava77 thanks for the reminder.
I have my branch with the new GT, but of course I forgot to make a PR.
This should go in both 74X and 75X, then in 75X we will switch to the new condition object, as discussed in the alca hn.

@diguida
Copy link
Contributor

diguida commented Mar 11, 2015

@yslai @slava77
This PR is now part of #8212 containing also the new GT for 75X

@diguida
Copy link
Contributor

diguida commented Mar 11, 2015

@yslai @slava77
This PR is now part of #8213 containing also the new GT for 74X

@diguida
Copy link
Contributor

diguida commented Mar 11, 2015

@slava77 FYI, this is what we discussed with HI group.
We agreed to move the calibration information for the Voronoi UE algorithm to the JetCorrectionsParameterCollection as interim/compatibility DB format in 74X/75X with the following steps:

  1. Prepare pull requests in 74X and 75X;
  2. Upload the new payloads which differs in naming from the final one, i.e. something with "compatibility" in name.

The new records are needed for the following scenarios:

  1. Run1 simulations for HI and pPb
  2. Run2 simulations for HI
  3. Run1 and Run2 data, not including HLT.

So, they were queued on the corresponding queues in the Global Tag Collector.

Once these PR are in, for 75X only, we should do:

  1. Ask the AlCaDB conveners and DB expert to create the new mapping in CondDBv1 for the new object: the new type is UETable, and is available in CMSSW_7_4_0_pre8;
  2. Once the dropbox is moved to the same releaseCMSSW_7_4_0_pre8, the new payloads can be uploaded;
  3. You can finally queue the tags in the GT, to the same queues as the "compatibility" ones;
  4. You make a PR in 75X;
  5. If requested, we back port this in 74X, thus removing the compatible payloads from the GT.

Please let us know if you have feedback.

@slava77
Copy link
Contributor

slava77 commented Mar 12, 2015

-1

superseded by #8213

@nclopezo nclopezo closed this Mar 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants