Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to JetCorrectorParametersCollection compatibility DB object with new Global Tags #8212

Merged
merged 3 commits into from Mar 15, 2015

Conversation

diguida
Copy link
Contributor

@diguida diguida commented Mar 11, 2015

Change to utilize the HIN Voronoi DB object in the "compatibility format", which is itself a JetCorrectorParametersCollection. Per discussion on Feb. 19, this change is done simultaneously to the Dropbox upload of the corresponding DB objects, originally in #7907

New Global Tags compatible with HI reconstruction:

  • Run1 HI and pA simulations:
    • Added JetCorrectorParametersCollection compatibility Records and labels for HI Voronoi algorithm,
    • Removed ExtendedTest SIM geometry (the test is successful, it is default Run1 geometry),
    • Updated ExtendedZeroMaterial SIM geometry to be in synch with new default;
  • Run2 HI simulations:
    • Added JetCorrectorParametersCollection compatibility Records and labels for HI Voronoi algorithm,
    • Updated RECO BeamSpot to be in synch with RealisticHICollisions2011 vertex smearing (currently used also for Run2 HI SIM BeamSpot), as in the Legacy HI MC;
  • Run1 and Run2 data:
    • Added JetCorrectorParametersCollection compatibility Records and labels for HI Voronoi algorithm.

Rebased on top of CMSSW_7_4_X_2015-03-11-0200

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_7_5_X.

Switch to JetCorrectorParametersCollection compatibility DB object with new Global Tags

It involves the following packages:

Configuration/AlCa
RecoHI/HiJetAlgos

@nclopezo, @cvuosalo, @cerminar, @cmsbuild, @diguida, @slava77, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @yslai, @jazzitup, @richard-cms, @appeltel, @yenjie, @kurtejung, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida
Copy link
Contributor Author

diguida commented Mar 11, 2015

For testing, I chose two HI wf (one already in the short matrix):

$ runTheMatrix.py -nel 140.1,140.53 -i all
140.1  QCD_Pt_80_120_13_HIINPUT+DIGIHI+RECOHI+HARVESTHI [1]: input from: /RelValQCD_Pt_80_120_13_HI/CMSSW_7_4_0_pre7-MCHI2_74_V3-v1/GEN-SIM with run []
                                           [2]: cmsDriver.py step2  --conditions auto:run2_mc_HIon --scenario HeavyIons -n 2 --eventcontent FEVTDEBUGHLT -s DIGI:pdigi_valid,L1,DIGI2RAW,HLT:HIon,RAW2DIGI,L1Reco --datatier GEN-SIM-DIGI-RAW-HLTDEBUG --beamspot RealisticHI2011Collision --customise SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1_HI --magField 38T_PostLS1 --inputCommands "keep *","drop *_simEcalPreshowerDigis_*_*"
                                           [3]: cmsDriver.py step3  --conditions auto:run2_mc_HIon -s RAW2DIGI,L1Reco,RECO,VALIDATION,DQM -n 2 --eventcontent RECOSIM,DQM --scenario HeavyIons --datatier GEN-SIM-RECO,DQMIO --beamspot RealisticHI2011Collision --customise SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1_HI --magField 38T_PostLS1
                                           [4]: cmsDriver.py step4  --conditions auto:run2_mc_HIon --scenario HeavyIons -s HARVESTING:validationHarvesting+dqmHarvesting --filetype DQM --customise SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1_HI --mc  --magField 38T_PostLS1 -n 100

140.53 RunHI2011+RECOHID11+HARVESTDHI      [1]: input from: /HIMinBiasUPC/HIRun2011-v1/RAW with run [182124]
                                           [2]: cmsDriver.py step2  --conditions auto:run1_data -s RAW2DIGI,L1Reco,RECO,ALCA:SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBiasHI+HcalCalMinBias,DQM --process reRECO -n 30 --data  --eventcontent RECO,DQM --scenario HeavyIons --datatier RECO,DQMIO --repacked
                                           [3]: cmsDriver.py step3  --data  --filetype DQM --conditions auto:run1_data --scenario HeavyIons -s HARVESTING:dqmHarvesting -n 100

They are running fine:

140.1_QCD_Pt_80_120_13_HI+QCD_Pt_80_120_13_HIINPUT+DIGIHI+RECOHI+HARVESTHI Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Wed Mar 11 22:01:19 2015-date Wed Mar 11 21:55:35 2015; exit: 0 0 0 0
140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI Step0-PASSED Step1-PASSED Step2-PASSED  - time date Wed Mar 11 22:08:01 2015-date Wed Mar 11 21:55:37 2015; exit: 0 0 0
2 2 2 1 tests passed, 0 0 0 0 failed

@diguida
Copy link
Contributor Author

diguida commented Mar 11, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@diguida
Copy link
Contributor Author

diguida commented Mar 12, 2015

This is the plan discussed with HI group.
We agreed to move the calibration information for the Voronoi UE algorithm to the JetCorrectionsParameterCollection as interim/compatibility DB format in 74X/75X with the following steps:

  1. Prepare pull requests in 74X and 75X;
  2. Upload the new payloads which differs in naming from the final one, i.e. something with "compatibility" in name.

The new records are needed for the following scenarios:

  1. Run1 simulations for HI and pPb
  2. Run2 simulations for HI
  3. Run1 and Run2 data, not including HLT.

So, they were queued on the corresponding queues in the Global Tag Collector.

Once these PR are in, for 75X only, we should do:

  1. Ask the AlCaDB conveners and DB expert to create the new mapping in CondDBv1 for the new object: the new type is UETable, and is available in CMSSW_7_4_0_pre8;
  2. Once the dropbox is moved to the same releaseCMSSW_7_4_0_pre8, the new payloads can be uploaded;
  3. You can finally queue the tags in the GT, to the same queues as the "compatibility" ones;
  4. You make a PR in 75X;
  5. If requested, we back port this in 74X, thus removing the compatible payloads from the GT.

Feedback by stakeholders is welcome.

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cvuosalo
Copy link
Contributor

+1

For #8212 d4fd5a2

This PR makes changes to utilize the HIN Voronoi DB object in the "compatibility format" for HI reco. It is the same as #8213 that is aimed at 74X.

Jenkins tests are OK, except for the comparison with baseline that did not complete for reasons not related to this PR. Short matrix tests against baseline CMSSW_7_5_X_2015-03-11-1400 show no significant differences.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants