-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix chimney hole #835
Fix chimney hole #835
Conversation
A new Pull Request was created by @TaiSakuma (Tai Sakuma) for CMSSW_5_3_X. Fix chimney hole It involves the following packages: Geometry/CMSCommonData @Dr15Jones, @ianna, @ktf can you please review it and eventually sign? Thanks. |
This should be compared to an engineering drawing before it goes to a release. As far as I remember, there was a fix for that already. |
There was a fix from February 2012 to fix not only the rotation, but also a union shape subtracted from the volume which was not correct. |
@TaiSakuma please, test 57cd68d |
This is with 1e4c6fe and 57cd68d The image looks the same as the screenshot from @ianna's but looks different from Fig 9.1. Without 1e4c6fe, the height of CHIMNEY_HOLE_P and CHIMNEY_HOLE_N will be too short for the solid subtraction. It will be exactly the same as the thickness of the wall of the MGNT. And since MGNT has a cylindrical shape and its wall is curved, the solid to subtract needs to be somewhat taller than the thickness of the wall. |
Thanks, Tai! Yana On Sep 17, 2013, at 3:09 PM, Tai Sakuma wrote:
Ianna Osborne |
hmm... the shape is correct, but it seems too big in comparison with the other one. On Sep 17, 2013, at 3:09 PM, Tai Sakuma wrote:
Ianna Osborne |
I agree. At least the chimney itself is much smaller from this photo Also, the magnet seems to have another hole from a different angle with all cables. |
-1 |
I see. I tried drawing MGNT_1 and CHIMNEY_HOLE_N. dz of CHIMNEY_HOLE_N is the original value of [ChimHole_height], i.e. ([MGNT_rmax2]-[MGNT_rmin])/2. I think CHIMNEY_HOLE_N is too long for an inner opening (and too short for a hole). Or if this is an inner opening, it needs to be bent to much the curvature of the MGNT. But perhaps, this might not be important in CMSSW. Personally, I prefer this to be fixed because the solid subtraction fails in SketchUp and causes an error. But if this doesn't need to be fixed in CMSSW, I will probably just release some patch from SketchUpCMS/cmssw for SketchUp. |
For the record. This will not make CMSSW_5_3_12_patch2 since it was not fully signed before the deadline for it. |
After discussing with ianna, this is actually not going into 53X at all. Closing this. |
ChimHole_height was a bit too short for the solid subtractions to work properly. I made it long enough for the subtractions to succeed.
I think that the chimney hole was rotated to a wrong angle. I changed the angle such that the orientation of the hole makes more sense on the magnet.