Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry fixes -- Fix chimney hole 70x #836

Closed

Conversation

TaiSakuma
Copy link
Contributor

The same request for 70X as #835

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @TaiSakuma (Tai Sakuma) for CMSSW_7_0_X.

Fix chimney hole 70x

It involves the following packages:

Geometry/CMSCommonData

@Dr15Jones, @ianna, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@nclopezo
Copy link
Contributor

+1
I ran the tests on top of CMSSW_7_0_X_2013-09-14-1400, because the IB of 09-16-0200 is not available on scram
https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc481/508/console
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/508

@ianna
Copy link
Contributor

ianna commented Sep 16, 2013

This should be compared to an engineering drawing before it goes to a release. As far as I remember, there was a fix for that already.

@ghost ghost assigned ianna Sep 16, 2013
@cmsbuild
Copy link
Contributor

The following categories have been rejected by yana (a.k.a. @ianna on GitHub): Geometry

@cms-git-visualization, @cms-git-geometry

@ktf
Copy link
Contributor

ktf commented Oct 4, 2013

closing this for now. Whenever you converge please reopen it.

@ktf ktf closed this Oct 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants