Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for electrons stream #9112

Closed
wants to merge 1 commit into from

Conversation

rgerosa
Copy link
Contributor

@rgerosa rgerosa commented May 15, 2015

Update of electron stream code :

  1. work with electrons selected from more than one HLT path
  2. dump more than one electron for each event in order to commission it also with Zee events

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rgerosa (raffaele gerosa) for CMSSW_7_5_X.

updates for electrons stream

It involves the following packages:

Calibration/EcalAlCaRecoProducers

@cmsbuild, @mmusich, @diguida, @cerminar, @nclopezo can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida
Copy link
Contributor

diguida commented May 15, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@perrotta
Copy link
Contributor

Please provide also a backport to 74X if you even want it used in the HLT for 2015 data taking

@mmusich
Copy link
Contributor

mmusich commented May 19, 2015

@perrotta, this was adressed first in 7.4.X through #9111. We asked to move to 7.5.X and after this is merged re-open the backport

@perrotta
Copy link
Contributor

Ah, ok, thank you @mmusich
It wouldn't be bad if companion pull requests are always linked as reference in the comment fields, in order to ease bookkeeping and evaluation: well, now the link to the 74X counterpart of this PR is there :-)

@rgerosa
Copy link
Contributor Author

rgerosa commented May 21, 2015

What is the status of the this PR? we would like to have a fast back port to 74X

@diguida
Copy link
Contributor

diguida commented May 21, 2015

@rgerosa I am looking into it. Busy days now...

@diguida
Copy link
Contributor

diguida commented May 26, 2015

-1
superseded by #9256

@nclopezo nclopezo closed this May 26, 2015
@diguida
Copy link
Contributor

diguida commented May 26, 2015

@rgerosa your commit has been merged into #9256
The changes you did are fine for us, but, as reported in #5772 (comment) there are still some optimisations to be done. I will point you to the code sections where the changes should be made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants