Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron stream plugin fix #9256

Merged
merged 3 commits into from Jun 8, 2015

Conversation

shervin86
Copy link
Contributor

This fixes the absence of the SelectedElectronFEDListProducer after the merge of PR #8306
The .cc and .h of the plugin has been moved to the plugin directory and now compiles.
Now the plugin is correctly restored as in any 75X pre release before #8306.

To avoid conflicts I have already merged with #9112.
This can PR can be merged after that or at the place of.

@davidlange6 @rgerosa @amassiro

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @shervin86 for CMSSW_7_5_X.

Electron stream plugin fix

It involves the following packages:

Calibration/EcalAlCaRecoProducers

@cmsbuild, @mmusich, @diguida, @cerminar, @nclopezo can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1
Tested at: 54d4eb8
I found an error when building:

>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-23-2300/src/Calibration/EcalAlCaRecoProducers/plugins/AlCaECALRecHitReducer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-23-2300/src/Calibration/EcalAlCaRecoProducers/plugins/AlCaElectronTracksReducer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-23-2300/src/Calibration/EcalAlCaRecoProducers/plugins/PUDumper.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-23-2300/src/Calibration/EcalAlCaRecoProducers/plugins/SelectedElectronFEDListProducer.cc 
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-23-2300/src/Calibration/EcalAlCaRecoProducers/plugins/SelectedElectronFEDListProducer.cc:1:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-23-2300/poison/Calibration/EcalAlCaRecoProducers/interface/SelectedElectronFEDListProducer.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
  ^
>> Building shared library tmp/slc6_amd64_gcc491/src/FWCore/Version/src/FWCoreVersion/libFWCoreVersion.so
Copying tmp/slc6_amd64_gcc491/src/FWCore/Version/src/FWCoreVersion/libFWCoreVersion.so to productstore area:
Leaving library rule at FWCore/Version


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9256/5012/summary.html

@shervin86
Copy link
Contributor Author

I have fixed it. I don't know why when I had compiled with scram I got no errors...
Now it compiles with scram b vclean && scram b -k -j 8

@cmsbuild
Copy link
Contributor

Pull request #9256 was updated. @cmsbuild, @mmusich, @diguida, @cerminar, @nclopezo can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@shervin86
Copy link
Contributor Author

@davidlange6 @Degano @smuzaffar can this be merged?

@emanueledimarco
Copy link
Contributor

In order to have the #9085 integrated, can we merge this, when possible?

@davidlange6
Copy link
Contributor

+1
Done - but for the backport please also remove the try -catch blocks if possible (I think it is)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants