Bugfixes and updates to the geometry comparison tool #9200
Conversation
…nd update to compare the rotation of modules
|
A new Pull Request was created by @cschomak for CMSSW_7_5_X. Bugfixes and updates to the geometry comparison tool It involves the following packages: Alignment/OfflineValidation @cmsbuild, @mmusich, @diguida, @cerminar, @nclopezo can you please review it and eventually sign? Thanks. |
| {"zeroAPE":{"connectString": ("frontier://FrontierProd" | ||
| "/CMS_COND_31X_FROM21X"), | ||
| "tagName": "TrackerIdealGeometryErrors210_mc", | ||
| {"zeroAPE":{"connectString": ("frontier://PromptProd" |
There was a problem hiding this comment.
why PromptProd? It cannot be used for tests as it is the Tier-0 servlet. Please use FrontierProd
There was a problem hiding this comment.
Changing this line was one of the main fixes to get the extended alignment parameter errors working. I had a look at the recent global tags and there TrackerAlignmentErrorExtendedRcd has frontier://PromptProd/CMS_COND_ALIGN_000 as PFN
Since I am new to alignment I am not sure what else to use.
There was a problem hiding this comment.
@cschomak please move to condDBv2 interface using frontier://FrontierProd/CMS_CONDITIONS PFN
There was a problem hiding this comment.
I did the changes you suggested
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
alca-pending
comparison-pending
and removed
alca-pending
comparison-pending
orp-pending
pending-signatures
tests-started
labels
| #process.load("Alignment.CommonAlignmentProducer.GlobalPosition_Frontier_cff") | ||
| # the input .GlobalPosition_Frontier_cff is providing the frontier://FrontierProd/CMS_COND_31X_ALIGNMENT in the release which does not provide the ideal geometry | ||
| #process.GlobalPosition.connect = 'frontier://FrontierProd/CMS_COND_31X_FROM21X' | ||
| process.load("Geometry.TrackerGeometryBuilder.trackerGeometry_cfi")i") |
There was a problem hiding this comment.
@cschomak - I assume, it's a typo - )"i")
There was a problem hiding this comment.
@ianna thanks for checking!
There was a problem hiding this comment.
Yes it is a typo, probably I made it when erasing commented links this morning.
Do I need to change the pull request? Unfortunately, I am travelling at the moment and not sure whether our cheap hotel has wifi tonight.
Can someone of you fix it?
|
-1 |
Bugs fixed that were introduced by changing from normal to extended alignment parameter errors
Added comparison of the rotations of individual modules to the plots