Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes and updates to the geometry comparison tool (v2) #9204

Merged
merged 3 commits into from May 22, 2015

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 21, 2015

this was already in #9200. One bug fix more

@mmusich mmusich changed the title Bugfixes and updates to the geometry comparison tool Bugfixes and updates to the geometry comparison tool (v2) May 21, 2015
@mmusich
Copy link
Contributor Author

mmusich commented May 21, 2015

@cschomak @diguida @ianna this fixes the small bug in #9200

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_7_5_X.

Bugfixes and updates to the geometry comparison tool (v2)

It involves the following packages:

Alignment/OfflineValidation

@cmsbuild, @mmusich, @diguida, @cerminar, @nclopezo can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @frmeier, @tlampen this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor Author

mmusich commented May 21, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor Author

mmusich commented May 22, 2015

+1
given the request already implemented in #9200

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants