Deprecate hbhe noise filter

[igv4321]

Removing the HBHENoiseFilter module. See
https://twiki.cern.ch/twiki/bin/view/CMS/HCALNoiseFilterRecipe
for updated noise filtering recommendations from the HCAL Noise workgroup.

[cmsbuild]

A new Pull Request was created by @igv4321 for CMSSW_7_5_X.

Deprecate hbhe noise filter

It involves the following packages:

CommonTools/RecoAlgos
PhysicsTools/PatAlgos
RecoMET/METFilters

@nclopezo, @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @imarches, @makortel, @acaudron, @abbiendi, @mmarionncern, @jhgoh, @ahinzmann, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

-1
Tested at: 14b3d6d
I found an error when building:

Entering library rule at src/DQMOffline/JetMET/plugins
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-26-2300/src/DQMOffline/JetMET/src/BeamHaloAnalyzer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-26-2300/src/DQMOffline/JetMET/src/CaloTowerAnalyzer.cc 
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-26-2300/src/DQMOffline/JetMET/interface/CaloTowerAnalyzer.h:18:0,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-26-2300/src/DQMOffline/JetMET/src/CaloTowerAnalyzer.cc:1:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-26-2300/poison/CommonTools/RecoAlgos/interface/HBHENoiseFilter.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
  ^
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-26-2300/src/DQMOffline/JetMET/src/CaloTowerAnalyzer.cc:57:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-26-2300/poison/CommonTools/RecoAlgos/interface/HBHENoiseFilter.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9286/3861/summary.html

[civanch]

+1

[slava77]

I went back to CMSSW_7_5_X_2015-05-27-1100 and ran the matrix tests there /my test area test9286/.
I observe no changes in comparisons with the baseline neither in the DQM nor in the validateJR, as I expected for this PR (certainly not any changes in tracking plots).
jenkins tests, before they disappeared, also showed no differences in validateJR (as I observed on Saturday May 30).

Carl, maybe you could check this on your side.
Could it be that somehow the diff displayed was done with respect to some other PR or something else glitched.