adding a flag for isolated noise filter

[igv4321]

Add a flag for the isolated noise filter to the event as requested by the HCAL Noise Workgroup.

[cmsbuild]

A new Pull Request was created by @igv4321 for CMSSW_7_5_X.

adding a flag for isolated noise filter

It involves the following packages:

CommonTools/RecoAlgos

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @makortel, @abbiendi, @jhgoh, @ahinzmann this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: bfcd325
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9327/3901/summary.html

[cvuosalo]

@igv4321: HBHENoiseFilterResultProducer.cc is not thread-safe. Would you like to take this opportunity to make it thread-safe? Alternatively, it could be done in a later PR.

[cvuosalo]

+1

For #9327 bfcd325

Addition of a flag for the HCAL isolated noise filter. This new flag should not change monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-05-28-2300 show no significant differences, as expected. A file in this PR, HBHENoiseFilterResultProducer.cc, needs to be made thread-safe, but that could be done in a later PR.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[igv4321]

Let's do it next time. Do I understand correctly that the only change needed is to inherit the module from edm::stream::EDProducer<> ?

[cvuosalo]

@igv4321: edm::stream::EDProducer<> is the main change. You also have to check that the code doesn't depend on thread-unsafe header files. If it does, those have to be changed, too.

[davidlange6]

+1