[core] Rework the field lookups in base classes to avoid iteration.

[smuzaffar]

The past approach was slow but also does not allow us to migrate to llvm13 as
the CXXBasePath cannot take the lookup iterator anymore.

See llvm/llvm-project@0cb7e7c

[smuzaffar]

test parameters:

• full_cmssw = true
• enable_test = threading

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch cms/master/98718ca.

@cmsbuild, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

[smuzaffar]

please test for CMSSW_12_4_ROOT6_X

[smuzaffar]

please test

[cmsbuild]

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c51e3/23467/summary.html
COMMIT: c2da0e3
CMSSW: CMSSW_12_4_X_2022-03-28-1100/slc7_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/166/23467/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:


-- Configuring incomplete, errors occurred!
See also "/pool/condor/dir_167601/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/lcg/root/6.24.07-4eaebf1ed65742543512a8a79589936e/build/CMakeFiles/CMakeOutput.log".
See also "/pool/condor/dir_167601/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/lcg/root/6.24.07-4eaebf1ed65742543512a8a79589936e/build/CMakeFiles/CMakeError.log".
error: Bad exit status from /pool/condor/dir_167601/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.wxgoyi (%build)


RPM build errors:
Bad exit status from /pool/condor/dir_167601/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.wxgoyi (%build)



[vgvassilev]

@smuzaffar, is that a real failure?

[smuzaffar]

not really, somehow bot is not picking up the correct release to test. It should have used CMSSW_12_4_ROOT6_X but it is using CMSSW_12_4_X ( I am looking in to the issue)

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c51e3/23487/summary.html
COMMIT: c2da0e3
CMSSW: CMSSW_12_4_ROOT6_X_2022-03-27-2300/slc7_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/166/23487/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @missirol update of GEN-SIM inputs for Run-3 TSG tests cmssw#37393
• @cms-tsg-storm HLT menu development for 12_3_X [12_4_X] cmssw#37370
• @VinInn Patatrack: introduce pt-clamping in vertex sorting, add #tracks in track SOA cmssw#37281
• @Dr15Jones Make JobReport::reportReadBranches thread safe cmssw#37364
• @valeriadamante bug fix in vertex selection of L2TauTagNNProducer cmssw#37291
• @bsunanda Run3-124D Try to remove compilation warnings in L1Trigger/L1THGCalUtilities cmssw#37354
• @francescobrivio Add relval wf 139.005 to test the AlcaEcalPhiSym workflow for Run3 cmssw#37345
• @francescobrivio Fix tag names in DQM Fake BeamSpot clients cmssw#37376
• @jeongeun Clean up redundant edm ParameterSet existAs or exist in RecoMET cmssw#37313
• @bsunanda Phase2-hgx302A Use MessageLogger instead of cout in a number of analyzers in HGCalGeometry cmssw#37312
• @apsallid update modifier to V16 cmssw#37366
• @bsunanda Phase2-hgx302B Use MessageLogger for cout in the second set of Analyzers in HGCalGeometry cmssw#37321
• @smuzaffar Updated root to tip of branch v6-24-00-patches cmsdist#7722
• @mkirsano configure pythia8 to use hepmc3 and hepmc2 cmsdist#7724
• @fwyzard Update hwloc to version 2.7.1 cmsdist#7714
• @smuzaffar [ROOT6] Updated root to tip of branch master cmsdist#7726

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c51e3/23487/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c51e3/23487/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testSerializationEcalObjects had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 16376 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3583670
• DQMHistoTests: Total failures: 60665
• DQMHistoTests: Total nulls: 333
• DQMHistoTests: Total successes: 3522650
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -1325.9929999999986 KiB( 47 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 1461.475 KiB HLT/JME
• DQMHistoSizes: changed ( 11634.0,... ): 1.887 KiB HLT/Filters
• DQMHistoSizes: changed ( 11834.0 ): 2.249 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 39434.0,... ): -2527.102 KiB HGCAL/HGCalValidator
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: found differences in 6 / 47 workflows

[smuzaffar]

@vgvassilev , tests look good. Although one unit tests failed but I do not think that it is related to root change (as this uses boost serialization). I ran the failed tests from the PR build area ( /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/166/23487 ) and it worked.

[vgvassilev]

@vgvassilev , tests look good. Although one unit tests failed but I do not think that it is related to root change (as this uses boost serialization). I ran the failed tests from the PR build area ( /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/166/23487 ) and it worked.

@smuzaffar, phew, thanks! Could you also comment on the root PR?

[smuzaffar]

I did :-) but with a simple message that cms tests passed :-)

[vgvassilev]

I did :-) but with a simple message that cms tests passed :-)

Sorry, too many things happening at the same time on my side :(

[cmsbuild]

Pull request #166 was updated.

[cmsbuild]

Pull request #166 was updated.