Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable proofd file server for XRootD>=5 #178

Merged
merged 1 commit into from
May 11, 2023

Conversation

smuzaffar
Copy link

Patch is needed in order to backport the XrootD>=5 in to root 6.12/14. This basically disables the XProofD file server and client support for XRootD versions>=5. Thanks to Christopher H Green and Kyle Knoepfel for providing this patch.

@cmsbuild
Copy link

cmsbuild commented May 3, 2023

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch cms/v6-14-00-patches/8ba6b0f.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Author

please test for CMSSW_10_6_X

@cmsbuild
Copy link

cmsbuild commented May 3, 2023

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b76671/32329/summary.html
COMMIT: c944534
CMSSW: CMSSW_10_6_X_2023-04-30-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/root/178/32329/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestFWCoreIntegrationInterProcess had ERRORS

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 102 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Author

+externals

@perrotta @rappoccio any objections on merging this for CMSSW 10.6.X . This change allows us to backport xrootd 5 to 10.6.X

@cmsbuild
Copy link

This pull request is fully signed and it will be integrated in one of the next cms/v6-14-00-patches/8ba6b0f IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link

+1

Yes, please merge this. Once we get them all together, I assume the checks will pass?

@iarspider
Copy link

@rappoccio the failed unit test is not related to this PR, I think it's just a glitch. I will restart the test just in case

@iarspider
Copy link

please test

@smuzaffar smuzaffar merged commit c5b9d2c into cms/v6-14-00-patches/8ba6b0f May 11, 2023
@cmsbuild
Copy link

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b76671/32569/summary.html
COMMIT: c944534
CMSSW: CMSSW_13_2_X_2023-05-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/178/32569/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:


-- Configuring incomplete, errors occurred!
See also "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/lcg/root/6.26.11-fe38957ec289fe627966ac63e6dbb7ac/build/CMakeFiles/CMakeOutput.log".
See also "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/lcg/root/6.26.11-fe38957ec289fe627966ac63e6dbb7ac/build/CMakeFiles/CMakeError.log".
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.w9YCH3 (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: lcg+root+6.26.11-fe38957ec289fe627966ac63e6dbb7ac
Macro expanded in comment on line 350: %{pkginstroot}/lib


@smuzaffar
Copy link
Author

no need to test it any more. Anyway test should have been requested for CMSSW_10_6_X :-)

@iarspider iarspider deleted the xrootd5-root614 branch May 11, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants