Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surgical Mask Side Sprite #1123

Closed
3 tasks done
Katskan opened this issue Sep 25, 2022 · 0 comments · Fixed by #2625
Closed
3 tasks done

Surgical Mask Side Sprite #1123

Katskan opened this issue Sep 25, 2022 · 0 comments · Fixed by #2625
Labels
Bug Admin events aren't bugs Sprites Remove the soul from the game.

Comments

@Katskan
Copy link
Contributor

Katskan commented Sep 25, 2022

Description

According to StanAlbatross, it is a bug that the side view of the surgical mask loops underneath of the nose and not above it, and not an issue with the sprite just being kind of bad.

Difference between expected and actual behavior

Surgical masks when worn properly should cover the entire mouth, down below the chin, and up above the tip of the nose so that speaking and turning the head does not displace the mask.

Steps to reproduce

Simply equip a surgical mask and turn to either side, then focus in on the nose.

Issue bingo (not required to be all checked)

@Doom-external Doom-external added Bug Admin events aren't bugs Sprites Remove the soul from the game. labels Oct 9, 2022
harryob pushed a commit that referenced this issue Feb 24, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->

# About the pull request
This PR fixes #1123
Humans' noses stick out of their sterile masks when they face the side,
so I fixed it.

Before

![image](https://user-images.githubusercontent.com/13158711/218229554-2183132b-ac22-404c-b8a7-5db5b84a4675.png)

After:

![image](https://user-images.githubusercontent.com/13158711/218230242-e8744023-4b73-4ef4-a14e-fc769cc6dd26.png)
<!-- Remove this text and explain what the purpose of your PR is.


Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game
Nobody wants spess covid. 
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding, and may discourage maintainers from reviewing or merging
your PR. This section is not strictly required for (non-controversial)
fix PRs or backend PRs. -->

# Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. Please note that
maintainers freely reserve the right to remove and add tags should they
deem it appropriate. You can attempt to finagle the system all you want,
but it's best to shoot for clear communication right off the bat. -->
<!-- If you add a name after the ':cl', that name will be used in the
changelog. You must add your CKEY after the CL if your GitHub name
doesn't match. Be sure to properly mark your PRs to prevent unnecessary
GBP loss. Maintainers freely reserve the right to remove and add tags
should they deem it appropriate. -->

:cl: Puckaboo2
fix: Humans will now cover their noses when they wear surgical masks.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Admin events aren't bugs Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants