Fixes the equipment attach point being on the wrong plane #5475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Jan 18, 2024
cm13-github
added a commit
that referenced
this pull request
Jan 18, 2024
This was referenced Jan 19, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 20, 2024
# About the pull request Fixes #5494 that I broke with #5475 sorry # Explain why it's good for the game You can attach engines/weapons to the dropships again _and_ not have xeno structures layer below the floor attach points. # Testing Photographs and Procedure 1. Attach various equipment to the dropships 2. See if they show up 3. Spawn xeno structures on the floor attach points see screenshots below <details> <summary>Screenshots & Videos</summary>     </details> # Changelog :cl: fix: Fixes engine/weapon attach points layering below the dropship walls. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Currently, the equipment attach points (the ones on the Alamo and the Normandy) are on the basic atom layer, -6. This causes certain effects, such as hive clusters or egg morphers layer below it (that are on
FLOOR_PLANE, -7).See the images for a before and after.
Explain why it's good for the game
No weird layering. Hive clusters are now visible when placed on the same tile as attach points.
Testing Photographs and Procedure
Screenshots & Videos
Before:
After:
Changelog
🆑
fix: Special xeno structures no longer layer below the Alamo and Normandy's equipment attach points.
/:cl: