Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support For Additional Search Filters #44

Closed
apavlo opened this issue Nov 16, 2018 · 2 comments
Closed

Add Support For Additional Search Filters #44

apavlo opened this issue Nov 16, 2018 · 2 comments
Assignees

Comments

@apavlo
Copy link
Member

apavlo commented Nov 16, 2018

There are the additional meta-data fields for systems that we are not able to search on right now. The only meta-fields that we currently support are the following:

  1. Compatible With: https://dbdb.io/browse?compatible=mysql
  2. Derived From: https://dbdb.io/browse?derived=tikv
  3. Inspired By: https://dbdb.io/browse?inspired=spanner
  4. Country: https://dbdb.io/browse?country=US

We need to add filtering for these additional fields:

  1. Operating System
  2. Programming Languages
  3. Project Type
  4. Licenses

We also need to support mixing the filters. It looks like we support that now but the search result label only includes the one of the filters:

https://dbdb.io/browse?derived=postgresql&country=US

This because the template code is just a bunch of if-else statements:

https://github.com/cmu-db/dbdb.io/blob/master/templates/core/database-browse.html#L113-L149


I don't know if there is a more generic way we should be performing these searches or whether it should be ad-hoc like we are doing now:

https://github.com/cmu-db/dbdb.io/blob/master/dbdb/core/views.py#L307-L346

@pembo13
Copy link
Collaborator

pembo13 commented Nov 20, 2018

@apavlo I think I can come up with a generator for the English language representation of the search. Adding the new filters should be simple enough, but everything together should be 1hr to 2hrs.

I'll work on this after #45

@pembo13
Copy link
Collaborator

pembo13 commented Dec 5, 2018

The index will need to be rebuilt: python manage.py rebuild_index --noinput

@pembo13 pembo13 closed this as completed Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants