Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Error catching for internal tasks (queries) #1555

Open
linmagit opened this issue Apr 20, 2021 · 1 comment
Open

Error catching for internal tasks (queries) #1555

linmagit opened this issue Apr 20, 2021 · 1 comment
Labels
infrastructure Infrastructure related issues or changes (CMake, dependencies, CI) question/discussion Further information is requested.

Comments

@linmagit
Copy link
Member

We added support for internal tasks in #1502, but we don't catch the errors when the internal tasks fail. Instead, we just print our error log messages from the command line. We should discuss how we really want to handle these errors.
@linmagit linmagit added question/discussion Further information is requested. infrastructure Infrastructure related issues or changes (CMake, dependencies, CI) labels Apr 20, 2021
@linmagit
Copy link
Member Author

Based on the discussion during today's team meeting, we're going to return the internal task execution status (e.g., success/failure) through a Future and let the caller decide how to handle that. So I think our infrastructure for DML tasks already supports that, but we should also support that for the DDL tasks, e.g., during the DBMS start time to create the internal tables.

@17zhangw 17zhangw mentioned this issue Apr 22, 2021
Merged
linmagit pushed a commit that referenced this issue May 5, 2021
@17zhangw
Internal Query Execution Status (Issue #1555) (#1561)
e8fd9b0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
infrastructure Infrastructure related issues or changes (CMake, dependencies, CI) question/discussion Further information is requested.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@linmagit