This repository has been archived by the owner on Sep 27, 2019. It is now read-only.
Transaction State Handler #1410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tli2
suggested changes
Jun 17, 2018
| ENDED, | ||
| }; | ||
|
|
||
| class TransactionStateHandler { |
There was a problem hiding this comment.
Maybe instead of TransactionStateHandler, call it ClientTransactionHandle or something like that, since this component stores all relevant information in the network layer about what a client's transaction is doing, instead of performing anything on transactions.
| @@ -0,0 +1,45 @@ | |||
| #pragma once | |||
| @@ -2,11 +2,11 @@ | |||
| // | |||
| // Peloton | |||
| // | |||
| // traffic_cop.h | |||
There was a problem hiding this comment.
This doesn't look like your intended changes.
|
Will be incorporated into larger network refactor PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR try to fix the transaction bug #1296 and do some refactor for traffic_cop by adding a wrapper around transaction context and manager.