-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve "... may be used in an incorrect context" check warnings #465
Comments
Hm, we've had this warning for a while. I didn't think it was causing CI failures. What about |
That's what I thought, but I didn't originally see any other warnings and Ctrl+F didn't seem to work. Perhaps the 2 warnings actually were actually "checking for code/documentation mismatches ... WARNING" and "checking Rd \usage sections ... WARNING" from not running document, rather than " Warning: : ... may be used in an incorrect context (/home/runner/work/epiprocess/epiprocess/check/epiprocess.Rcheck/00_pkg_src/epiprocess/R/slide.R:307)" and "Warning: : ... may be used in an incorrect context (/home/runner/work/epiprocess/epiprocess/check/epiprocess.Rcheck/00_pkg_src/epiprocess/R/grouped_epi_archive.R:320)". CI auto-document didn't trigger a re-check. Let me try to force one.
|
Okay, looks like it was the lack of document() causing the warnings that actually counted toward that check error. This is lower priority but probably good to get rid of some check warning spam and any future confusion like mine above. I'm not 100% sure |
This appears to be causing checks to be marked as failures.We do this very deliberately here (and probably in an analogous spot forepix_slide
s); iff
is missing then..1
is a tidy computation, not an argument to the computation. This makes it happen.Some possible resolutions:
..1
to a function (withinas_slide_computation
) take in dots and ignore them, and remove the... <- missing_arg()
lines....
tof
: either...
for arg passing, oras_slide_computation
bake any args intof
iff
is a function, rather than usef
as-is (something likereturn(function(x,gk,rtv) f(x,gk,rtv,...))
, and no longer pass...
to computations within thegroup_modify
computations ofepi[x]_slide
. For efficiency's sake, only do this if there are a nonzero number of dots.@nmdefries do these sound like solutions? Any preferences?
The text was updated successfully, but these errors were encountered: