Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign to dots using assign to avoid CI warning #468

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Jun 20, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • Request a review from one of the current main reviewers:
    brookslogan, nmdefries.
  • Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).
  • See DEVELOPMENT.md for more information on the development
    process.

Change explanations for reviewer

... <- missing_arg() consistently causes warning in tests Warning: : ... may be used in an incorrect context. Switch to another way of assigning to the variable ... to avoid this.

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

Closes #465

Copy link
Contributor

@brookslogan brookslogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! My checks:

  • assign does appear equivalent (checked with f = function(x, ...) {assign("...", missing_arg()); g(x, ...)} etc.)
  • check warnings do seem to be gone, or at least browser C-f doesn't find them.

@brookslogan brookslogan merged commit 01d77aa into dev Jun 20, 2024
5 checks passed
@dshemetov dshemetov deleted the ndefries/dots-warning branch June 21, 2024 01:50
brookslogan added a commit to XuedaShen/epiprocess that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve "... may be used in an incorrect context" check warnings
2 participants