Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flesh out imageTag in makefile #289

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Flesh out imageTag in makefile #289

merged 2 commits into from
Jun 1, 2023

Conversation

nmdefries
Copy link
Collaborator

@nmdefries nmdefries commented May 31, 2023

@dsweber2 noticed that "the variable imageTag in the makefile isn't defined; presumably its an environmental variable, but it isn't mentioned in the readme at all". I've set a default for imageTag in the Makefile and described it's use, BUT it turns out that the two make targets that use this variable aren't used anywhere else in our code. Building, tagging, and releasing is done explicitly in the ci.yaml workflow rather than using make.

These two targets could be useful if we need to manually build and release a docker image for production (e.g. something goes wrong with the automated release process while we're trying to release a hotfix). But we haven't needed this yet and it does make the code longer. I'm open to arguments either way.

Fixes #287

Makefile Show resolved Hide resolved
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The targets are short so I say keep them in. The comments are a good reminder to double-check the yaml versions in case they lose sync.

@nmdefries nmdefries merged commit 711bba7 into dev Jun 1, 2023
@nmdefries nmdefries deleted the ndefries/doc-cleanup branch June 1, 2023 16:45
@nmdefries nmdefries mentioned this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker build errors
3 participants